Adding IP restrictions to Web App #1231
Conversation
There was a problem hiding this comment.
hey @paktek123
Thanks for this PR :)
I've taken a look through and left some comments inline - since this PR is so close, I hope you don't mind but I've pushed a couple of commits to fix the issues I've raised - and this now LGTM 👍
Thanks!
| "subnet_mask": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "255.255.255.255", |
There was a problem hiding this comment.
context from the Azure Portal: Specify an IP address range by providing a subnet mask (i.e. 255.255.255.0). If no mask is provided 255.255.255.255 is assumed.
|
|
||
| ip_restriction { | ||
| ip_address = "10.10.10.10" | ||
| subnet_mask = "255.255.255.255" |
There was a problem hiding this comment.
since it's defaulted, we can remove this value
|
|
||
| ip_restriction { | ||
| ip_address = "10.10.10.10" | ||
| subnet_mask = "255.255.255.255" |
azurerm/resource_arm_app_service.go
Outdated
| ipSecurityRestrictions := configResp.SiteConfig.IPSecurityRestrictions | ||
| if ipSecurityRestrictions != nil { | ||
| d.Set("ip_restrictions", flattenAppServiceIpRestrictions(ipSecurityRestrictions)) | ||
| } |
There was a problem hiding this comment.
we should set this all the time (but return an empty list) - I'll push a commit to fix this
azurerm/data_source_app_service.go
Outdated
| ipSecurityRestrictions := configResp.SiteConfig.IPSecurityRestrictions | ||
| if ipSecurityRestrictions != nil { | ||
| d.Set("ip_restriction", flattenAppServiceIpRestrictions(ipSecurityRestrictions)) | ||
| } |
There was a problem hiding this comment.
we should set this all the time (but return an empty list) - I'll push a commit to fix this
| @@ -123,6 +123,23 @@ func dataSourceArmAppService() *schema.Resource { | |||
| Computed: true, | |||
| }, | |||
|
|
|||
| "ip_restriction": { | |||
There was a problem hiding this comment.
can we add some additional documentation for these fields?
|
Ignoring a temporary connection error; the resource tests pass:
Also the Data Source tests pass:
|
|
Thanks @tombuildsstuff ! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
This is fix for issue #1157