Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Support migration of service_principal to identity #12049

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Jun 3, 2021

Fixes #11288

TO DO

  • Cover edge cases
  • Docs
  • Run tests (only servicePrincipal tests)

Acceptance Tests:

  • TestAccKubernetesCluster_servicePrincipal -> FAIL because I don't have a secondary principal specified
  • TestAccKubernetesCluster_servicePrincipalToSystemAssignedIdentity -> PASS
  • TestAccKubernetesCluster_servicePrincipalToUserAssignedIdentity -> PASS

@ghost ghost added the size/M label Jun 3, 2021
@aristosvo aristosvo changed the title azurerm_kubernetes_cluster: Support migration of service_principal to identity` azurerm_kubernetes_cluster: Support migration of service_principal to identity Jun 3, 2021
@aristosvo
Copy link
Collaborator Author

aristosvo commented Jun 3, 2021

@mbfrahry Another AKS upgrade 😄

I hope you don't mind, would you be able to run the whole AccTests suite? I don't have the resources at the moment.

@aristosvo aristosvo marked this pull request as ready for review June 3, 2021 15:48
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I just have some suggestions about presenting the info in the docs

website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
@aristosvo aristosvo requested a review from mbfrahry June 4, 2021 06:42
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.63.0 milestone Jun 4, 2021
@mbfrahry mbfrahry merged commit c261747 into hashicorp:master Jun 4, 2021
mbfrahry added a commit that referenced this pull request Jun 4, 2021
@aristosvo aristosvo deleted the feature/update-service-principal-to-identity branch June 5, 2021 09:31
@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
@aristosvo aristosvo restored the feature/update-service-principal-to-identity branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants