Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_eventhub_cluster #11763

Merged
merged 9 commits into from
May 19, 2021
Merged

New data source: azurerm_eventhub_cluster #11763

merged 9 commits into from
May 19, 2021

Conversation

favoretti
Copy link
Collaborator

New data source: azurerm_eventhub_cluster

New data source: `azurerm_eventhub_cluster`
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR :)

I've taken a look through and left a couple of comments inline but if we can fix those up then this otherwise LGTM 👍

Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a failing test:

 Error: Reference to undeclared resource
        
          on terraform_plugin_test.tf line 19, in data "azurerm_eventhub_cluster" "test":
          19:   name                = azurerm_eventhub.test.name
        
        A managed resource "azurerm_eventhub" "test" has not been declared in the

@jebaraa
Copy link

jebaraa commented May 19, 2021

🥳

@favoretti
Copy link
Collaborator Author

Fixed it all up, running acceptance test as we speak, will just take 4 hours while waiting for cluster to be destroyed.

@favoretti
Copy link
Collaborator Author

image

@favoretti favoretti added this to the v2.60.0 milestone May 19, 2021
@katbyte katbyte merged commit 2be1ddb into hashicorp:master May 19, 2021
katbyte added a commit that referenced this pull request May 19, 2021
@ghost
Copy link

ghost commented May 21, 2021

This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.60.0"
}
# ... other configuration ...

favoretti added a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants