-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PreAttack tactic to Sentinel scheduled alert rule #11750
Conversation
The missing PreAttack tactic was added to the azure-sdk-for-go v54.0.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just suggesting a change to be in line with the schema for Attack tactics, elsewise this is invalid. Made this change and put PreAttack in the tests and looks all good.
> $ TF_ACC=1 go test -v -timeout=2h ./azurerm/internal/services/sentinel -run="TestAccSentinelAlertRuleScheduled_complete" [±master ●]
2021/05/17 22:23:39 [DEBUG] not using binary driver name, it's no longer needed
2021/05/17 22:23:39 [DEBUG] not using binary driver name, it's no longer needed
=== RUN TestAccSentinelAlertRuleScheduled_complete
=== PAUSE TestAccSentinelAlertRuleScheduled_complete
=== CONT TestAccSentinelAlertRuleScheduled_complete
--- PASS: TestAccSentinelAlertRuleScheduled_complete (190.13s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel 190.255s
azurerm/internal/services/sentinel/sentinel_alert_rule_scheduled_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NVolcz - LGTM 👍
This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.60.0"
}
# ... other configuration ... |
The missing PreAttack tactic was added to the azure-sdk-for-go v54.0.0.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The missing PreAttack tactic was added to the azure-sdk-for-go v54.0.0.