-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
: Add ingress_application_gateway_identity
export for add-on ingress_application_gateway
#11622
azurerm_kubernetes_cluster
: Add ingress_application_gateway_identity
export for add-on ingress_application_gateway
#11622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aristosvo! This looks mostly good minus a couple things I called out below! Thanks for taking the time to get this PR out
azurerm/internal/services/containers/kubernetes_cluster_data_source.go
Outdated
Show resolved
Hide resolved
7befe81
to
3de080c
Compare
Thanks @mbfrahry! Sorry to bother you with correcting my Friday night code 😅 I think this should do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries at all and LGTM! Thanks for taking care of that!
kubernetes_cluster
: Add identity export for add-on ingress_application_gateway
azurerm_kubernetes_cluster
: Add ingress_application_gateway_identity
export for add-on ingress_application_gateway
This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.59.0"
}
# ... other configuration ... |
…ty` export for add-on `ingress_application_gateway` (hashicorp#11622)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #11564
Acceptance tests
New functionality tested and passing