-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_virtual_machine_configuration_policy_assignment
#11334
Conversation
Tests are passing on my local machine:
|
The CI failure might be able to be fixed by https://github.com/terraform-providers/terraform-provider-azurerm/pull/11335/files |
"azurerm_policy_definition": resourceArmPolicyDefinition(), | ||
"azurerm_policy_set_definition": resourceArmPolicySetDefinition(), | ||
"azurerm_policy_remediation": resourceArmPolicyRemediation(), | ||
"azurerm_virtual_machine_configuration_policy_assignment": resourceVirtualMachineConfigurationPolicyAssignment(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if that was addressed in the old pr, i looked but did see it: there is assignment in the name yet the policy is inlined? does that mean this would make more sense as
"azurerm_virtual_machine_configuration_policy_assignment": resourceVirtualMachineConfigurationPolicyAssignment(), | |
"azurerm_virtual_machine_configuration_policy": resourceVirtualMachineConfigurationPolicyAssignment(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought on this resource name is that we need to emphasize that this is an assignment like azurerm_policy_assignment
- creation of this resource will make the policy enabled on the target, therefore I kept the word "assignment" in the resource name. With the assignment, this resource reads like a policy definition
Therefore I suggest we keep the word assignment in the resource name, despite it might be long
azurerm/internal/services/policy/virtual_machine_configuration_policy_assignments_resource.go
Outdated
Show resolved
Hide resolved
website/docs/r/virtual_machine_configuration_policy_assignment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/virtual_machine_configuration_policy_assignment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/virtual_machine_configuration_policy_assignment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/virtual_machine_configuration_policy_assignment.html.markdown
Outdated
Show resolved
Hide resolved
Hey @katbyte I have resolved the comments, please take a look, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This is a reopen of PR #10748
Guest Configuration is to audit settings inside a virtual machine, the validation can validate the settings such like:
For more information, please refer to the doc page here: https://docs.microsoft.com/en-us/azure/governance/policy/concepts/guest-configuration