-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/(linux|windows)_virtual_machine(_scale_set): support for Force Delete #11216
Merged
Commits on Apr 13, 2021
-
provider: adding a new feature flag for
force_delete
within the `vi……rtual_machine` block
Configuration menu - View commit details
-
Copy full SHA for ebc966c - Browse repository at this point
Copy the full SHA ebc966cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f093278 - Browse repository at this point
Copy the full SHA f093278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bd28ee - Browse repository at this point
Copy the full SHA 3bd28eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ca4372 - Browse repository at this point
Copy the full SHA 0ca4372View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aa1f0d - Browse repository at this point
Copy the full SHA 8aa1f0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b69bd - Browse repository at this point
Copy the full SHA f7b69bdView commit details -
features: adding a todo that we should investigate changing this defa…
…ult in 3.0 We can't do this now since the API errors if this preview functionality isn't enabled
Configuration menu - View commit details
-
Copy full SHA for 74ef98e - Browse repository at this point
Copy the full SHA 74ef98eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a5c6b - Browse repository at this point
Copy the full SHA 61a5c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12cfdc7 - Browse repository at this point
Copy the full SHA 12cfdc7View commit details -
provider: adding a feature-flag for conditionally shutting down the V…
…irtual Machine prior to deletion This is necessary since there's cost benefits to doing so with larger machines - whilst we could opt to do this automatically in the case of Force Delete based on the Service Teams description of this functionality, Force Delete should likely become the default in 3.x since it's more reliable for other items in the stack than a regular delete, however this can't be done yet until the feature leaves the preview period (as at the moment it's a public preview which errors if it's disabled) Ultimately this allows users who want to use Force Delete without shutting the VM can do so using both feature toggles together - whilst allowing the more resilient deletion (which will become the default at some point in the future) to be used with a gradual shut-down in the case of specific VM's where this can be useful.
Configuration menu - View commit details
-
Copy full SHA for 4fc77c8 - Browse repository at this point
Copy the full SHA 4fc77c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 424568c - Browse repository at this point
Copy the full SHA 424568cView commit details
Commits on May 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 18ae1e0 - Browse repository at this point
Copy the full SHA 18ae1e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf59ee3 - Browse repository at this point
Copy the full SHA bf59ee3View commit details
Commits on May 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ce86c9d - Browse repository at this point
Copy the full SHA ce86c9dView commit details
Commits on May 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a6b05c2 - Browse repository at this point
Copy the full SHA a6b05c2View commit details
Commits on May 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4a5d8f2 - Browse repository at this point
Copy the full SHA 4a5d8f2View commit details
Commits on May 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e12e301 - Browse repository at this point
Copy the full SHA e12e301View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.