Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/(linux|windows)_virtual_machine(_scale_set): support for Force Delete #11216

Merged
merged 17 commits into from
May 26, 2021

Commits on Apr 13, 2021

  1. Configuration menu
    Copy the full SHA
    ebc966c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f093278 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3bd28ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0ca4372 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8aa1f0d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f7b69bd View commit details
    Browse the repository at this point in the history
  7. features: adding a todo that we should investigate changing this defa…

    …ult in 3.0
    
    We can't do this now since the API errors if this preview functionality isn't enabled
    tombuildsstuff committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    74ef98e View commit details
    Browse the repository at this point in the history
  8. linting

    tombuildsstuff committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    61a5c6b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    12cfdc7 View commit details
    Browse the repository at this point in the history
  10. provider: adding a feature-flag for conditionally shutting down the V…

    …irtual Machine prior to deletion
    
    This is necessary since there's cost benefits to doing so with larger machines - whilst we could opt
    to do this automatically in the case of Force Delete based on the Service Teams description of this
    functionality, Force Delete should likely become the default in 3.x since it's more reliable for
    other items in the stack than a regular delete, however this can't be done yet until the feature
    leaves the preview period (as at the moment it's a public preview which errors if it's disabled)
    
    Ultimately this allows users who want to use Force Delete without shutting the VM can do so using
    both feature toggles together - whilst allowing the more resilient deletion (which will become
    the default at some point in the future) to be used with a gradual shut-down in the case of specific
    VM's where this can be useful.
    tombuildsstuff committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    4fc77c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    424568c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. combine flags

    katbyte committed May 12, 2021
    Configuration menu
    Copy the full SHA
    18ae1e0 View commit details
    Browse the repository at this point in the history
  2. update comments

    katbyte committed May 12, 2021
    Configuration menu
    Copy the full SHA
    bf59ee3 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. update docs

    katbyte committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ce86c9d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. merge master

    katbyte committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a6b05c2 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. make fmt

    katbyte committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4a5d8f2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. fix tests

    katbyte committed May 26, 2021
    Configuration menu
    Copy the full SHA
    e12e301 View commit details
    Browse the repository at this point in the history