Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_queue - support for setting requires_session #1111

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 10, 2018

Closes #1092

@katbyte katbyte added this to the 1.3.3 milestone Apr 10, 2018
@katbyte katbyte requested a review from a team April 10, 2018 23:58
@katbyte
Copy link
Collaborator Author

katbyte commented Apr 10, 2018

Tests pass:

make fmt; make testacc TEST=./azurerm TESTARGS=-test.run=TestAccAzureRMServiceBusQueue_enableRequiresSession
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMServiceBusQueue_enableRequiresSession -timeout 180m
=== RUN   TestAccAzureRMServiceBusQueue_enableRequiresSession
--- PASS: TestAccAzureRMServiceBusQueue_enableRequiresSession (173.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	173.812s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff changed the title Added requires_session to servicebus_queue azurerm_servicebus_queue - support for setting requires_session Apr 11, 2018
@tombuildsstuff tombuildsstuff merged commit 612735c into master Apr 11, 2018
@tombuildsstuff tombuildsstuff deleted the f-servicebus-queue-requires_session branch April 11, 2018 08:26
tombuildsstuff added a commit that referenced this pull request Apr 11, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for requiresSession property for Queues
2 participants