-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/ data source azurerm_postgresql_flexible_server
#11081
Conversation
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/postgres/postgresql_flexible_server_data_source.go
Show resolved
Hide resolved
Thanks for your comments, kt. All tests have passed. Please continue reviewing when the linter is fixed. |
azurerm/internal/services/postgres/postgresql_flexible_server_data_source.go
Outdated
Show resolved
Hide resolved
}, false), | ||
}, | ||
|
||
"zone": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a shared schema function you can use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shared schema is a list of string, while here it's a string, shall we change its type to use the shared schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AH good point! we only have a couple zone
- this is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68 - LGTM 👍
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix: #8654
#10455
=== RUN TestAccDataSourcePostgresqlflexibleServer_basic
=== PAUSE TestAccDataSourcePostgresqlflexibleServer_basic
=== CONT TestAccDataSourcePostgresqlflexibleServer_basic
--- PASS: TestAccDataSourcePostgresqlflexibleServer_basic (485.30s)
=== RUN TestAccPostgresqlflexibleServer_basic
=== PAUSE TestAccPostgresqlflexibleServer_basic
=== CONT TestAccPostgresqlflexibleServer_basic
--- PASS: TestAccPostgresqlflexibleServer_basic (744.14s)
=== RUN TestAccPostgresqlflexibleServer_requiresImport
=== PAUSE TestAccPostgresqlflexibleServer_requiresImport
=== CONT TestAccPostgresqlflexibleServer_requiresImport
--- PASS: TestAccPostgresqlflexibleServer_requiresImport (800.16s)
=== RUN TestAccPostgresqlflexibleServer_complete
=== PAUSE TestAccPostgresqlflexibleServer_complete
=== CONT TestAccPostgresqlflexibleServer_complete
--- PASS: TestAccPostgresqlflexibleServer_complete (1620.08s)
=== RUN TestAccPostgresqlflexibleServer_completeUpdate
=== PAUSE TestAccPostgresqlflexibleServer_completeUpdate
=== CONT TestAccPostgresqlflexibleServer_completeUpdate
--- PASS: TestAccPostgresqlflexibleServer_completeUpdate (3408.08s)
=== RUN TestAccPostgresqlflexibleServer_updateMaintenanceWindow
=== PAUSE TestAccPostgresqlflexibleServer_updateMaintenanceWindow
=== CONT TestAccPostgresqlflexibleServer_updateMaintenanceWindow
--- PASS: TestAccPostgresqlflexibleServer_updateMaintenanceWindow (1124.51s)
=== RUN TestAccPostgresqlflexibleServer_updateSku
=== PAUSE TestAccPostgresqlflexibleServer_updateSku
=== CONT TestAccPostgresqlflexibleServer_updateSku
--- PASS: TestAccPostgresqlflexibleServer_updateSku (1472.27s)
=== RUN TestAccPostgresqlflexibleServer_pitr
=== PAUSE TestAccPostgresqlflexibleServer_pitr
=== CONT TestAccPostgresqlflexibleServer_pitr
--- PASS: TestAccPostgresqlflexibleServer_pitr (2484.59s)