Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/ data source azurerm_postgresql_flexible_server #11081

Merged
merged 47 commits into from
Apr 20, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Mar 23, 2021

Fix: #8654
#10455

=== RUN TestAccDataSourcePostgresqlflexibleServer_basic
=== PAUSE TestAccDataSourcePostgresqlflexibleServer_basic
=== CONT TestAccDataSourcePostgresqlflexibleServer_basic
--- PASS: TestAccDataSourcePostgresqlflexibleServer_basic (485.30s)

=== RUN TestAccPostgresqlflexibleServer_basic
=== PAUSE TestAccPostgresqlflexibleServer_basic
=== CONT TestAccPostgresqlflexibleServer_basic
--- PASS: TestAccPostgresqlflexibleServer_basic (744.14s)
=== RUN TestAccPostgresqlflexibleServer_requiresImport
=== PAUSE TestAccPostgresqlflexibleServer_requiresImport
=== CONT TestAccPostgresqlflexibleServer_requiresImport
--- PASS: TestAccPostgresqlflexibleServer_requiresImport (800.16s)
=== RUN TestAccPostgresqlflexibleServer_complete
=== PAUSE TestAccPostgresqlflexibleServer_complete
=== CONT TestAccPostgresqlflexibleServer_complete
--- PASS: TestAccPostgresqlflexibleServer_complete (1620.08s)
=== RUN TestAccPostgresqlflexibleServer_completeUpdate
=== PAUSE TestAccPostgresqlflexibleServer_completeUpdate
=== CONT TestAccPostgresqlflexibleServer_completeUpdate
--- PASS: TestAccPostgresqlflexibleServer_completeUpdate (3408.08s)
=== RUN TestAccPostgresqlflexibleServer_updateMaintenanceWindow
=== PAUSE TestAccPostgresqlflexibleServer_updateMaintenanceWindow
=== CONT TestAccPostgresqlflexibleServer_updateMaintenanceWindow
--- PASS: TestAccPostgresqlflexibleServer_updateMaintenanceWindow (1124.51s)
=== RUN TestAccPostgresqlflexibleServer_updateSku
=== PAUSE TestAccPostgresqlflexibleServer_updateSku
=== CONT TestAccPostgresqlflexibleServer_updateSku
--- PASS: TestAccPostgresqlflexibleServer_updateSku (1472.27s)
=== RUN TestAccPostgresqlflexibleServer_pitr
=== PAUSE TestAccPostgresqlflexibleServer_pitr
=== CONT TestAccPostgresqlflexibleServer_pitr
--- PASS: TestAccPostgresqlflexibleServer_pitr (2484.59s)

@ghost ghost added the size/XXL label Mar 23, 2021
@yupwei68
Copy link
Contributor Author

Thanks for your comments, kt. All tests have passed. Please continue reviewing when the linter is fixed.

@yupwei68 yupwei68 requested a review from katbyte April 15, 2021 07:10
@katbyte katbyte modified the milestones: v2.56.0, v2.57.0 Apr 16, 2021
}, false),
},

"zone": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a shared schema function you can use here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared schema is a list of string, while here it's a string, shall we change its type to use the shared schema?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AH good point! we only have a couple zone - this is good

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit 4adcce3 into hashicorp:master Apr 20, 2021
katbyte added a commit that referenced this pull request Apr 20, 2021
@yupwei68 yupwei68 deleted the wyp-postgresql-flexible branch April 21, 2021 01:25
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PostgreSQL Flexible Server
6 participants