Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_management_group_subscription_association #11069

Merged
merged 9 commits into from
Mar 31, 2021

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Mar 22, 2021

closes #10912
closes #3555

Breaking Change Notes:
The introduction of the azurerm_management_group_subscription_association creates a breaking change in the use of azurerm_management_group. It is now required to explicitly set an empty list to remove all subscription_ids, where previously simply omitting this value would remove all Subscriptions from the Management group. Setting subscription_ids on azurerm_management_group is not supported when using azurerm_management_group_subscription_association.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops - LGTM aside from one minor comment. Also does this superseded #8947 ?

Comment on lines 94 to 95
_, err = client.Create(ctx, id.ManagementGroup, id.SubscriptionId, "")
if err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines could be merged

@jackofallops jackofallops modified the milestones: v2.53.0, v2.54.0 Mar 26, 2021
@jackofallops
Copy link
Member Author

Thanks @jackofallops - LGTM aside from one minor comment. Also does this superseded #8947 ?

That wasn't intentional, I didn't see that PR when I searched 🙈 , but yes this will replace that PR.

@jackofallops jackofallops merged commit 816fa8f into master Mar 31, 2021
jackofallops added a commit that referenced this pull request Mar 31, 2021
rm-hull added a commit to rm-hull/terraform-provider-azurerm that referenced this pull request Mar 31, 2021
…vider-azurerm

* 'master' of github.com:terraform-providers/terraform-provider-azurerm: (68 commits)
  Update changelog for hashicorp#11164
  `azurerm_cognitive_account` - Add support for `network_acls` (hashicorp#11164)
  Update CHANGELOG.md for hashicorp#11069
  New Resource: `azurerm_management_group_subscription_association` (hashicorp#11069)
  tests: limit running VMware tests in teamcity (hashicorp#11167)
  CHANGELOG.md for hashicorp#10627
  azurerm_firewall: support for private_ip_ranges (hashicorp#10627)
  Update CHANGELOG.md for hashicorp#11083
  Upgrade hpc cache API version to 2021-03-01 (hashicorp#11083)
  CHANGELOG.md for hashicorp#10724
  new resource: azurerm_media_live_event (hashicorp#10724)
  CHANGELOG.md for hashicorp#11108
  upgrade go sdk to v52.6.0 (hashicorp#11108)
  CHANGELOG.md for hashicorp#11139
  azurerm_api_management: make certificate_password optional (hashicorp#11139)
  CHANGELOG.md for hashicorp#10830
  r/azurerm_data_factory_linked_service_azure_blob_storage: Fixing managed identity implementation (hashicorp#10830)
  CHANGELOG.md for hashicorp#11131
  azurerm_storage_account - support for 'container_delete_retention_policy' (hashicorp#11131)
  CHANGELOG.md for hashicorp#11106
  ...
@ghost
Copy link

ghost commented Apr 2, 2021

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
@katbyte katbyte deleted the r/subscription-mg-association branch May 25, 2021 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.