Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault: waiting for 10 successful dns locators before returning as created #1081

Merged
merged 2 commits into from
Apr 24, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Apr 5, 2018

Switching over to ensure the DNS is resolved 10 times in a row before marking the KeyVault resource as successfully provisioned.

This should fix #655 but it's hard to tell since it fails sporadically:

* azurerm_key_vault_secret.test-secret: azurerm_key_vault_secret.test-secret: Error making Read request on Azure KeyVault Secret acctestsecret-5272604717641362572: keyvault.BaseClient#GetSecret: Failure sending request: StatusCode=0 -- Original Error: Get https://vault5272604717641362572.vault.azure.net/secrets/acctestsecret-5272604717641362572/?api-version=2016-10-01: dial tcp: lookup vault5272604717641362572.vault.azure.net on 192.168.22.2:53: no such host

@tombuildsstuff tombuildsstuff added this to the 1.3.3 milestone Apr 5, 2018
@tombuildsstuff tombuildsstuff changed the title azurerm_key_vault: waiting for 10 successful dns locators before returning as created [WIP] azurerm_key_vault: waiting for 10 successful dns locators before returning as created Apr 5, 2018
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming relevant tests pass

@tombuildsstuff tombuildsstuff modified the milestones: 1.3.3, Soon Apr 16, 2018
@pixelicous
Copy link

@tombuildsstuff was this merged to 1.3.3? Doesn't seem like it..

@tombuildsstuff
Copy link
Contributor Author

@pixelicous not yet, this is still WIP as this fix needs some additional tweaking

@pixelicous
Copy link

@tombuildsstuff thx! We opened a ficket with MS about this, as its related.. I remember writing you an official response from MS about how to handle that timeout but i cant seem to find which post it was on.. Ill post it again here if i dont find it soon, they are implementing a few changes but ita going to take a while probably

@tombuildsstuff tombuildsstuff force-pushed the key-vault-polling branch 2 times, most recently from 87c7036 to 676aeab Compare April 24, 2018 14:07
@tombuildsstuff tombuildsstuff changed the title [WIP] azurerm_key_vault: waiting for 10 successful dns locators before returning as created azurerm_key_vault: waiting for 10 successful dns locators before returning as created Apr 24, 2018
@tombuildsstuff
Copy link
Contributor Author

Also now fixes #1005

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

Key Vault tests pass:

screen shot 2018-04-24 at 16 55 24

@tombuildsstuff tombuildsstuff merged commit 7127722 into master Apr 24, 2018
@tombuildsstuff tombuildsstuff deleted the key-vault-polling branch April 24, 2018 14:56
tombuildsstuff added a commit that referenced this pull request Apr 24, 2018
@tombuildsstuff
Copy link
Contributor Author

hey @pixelicous

Just to let you know that v1.4.0 of the Azure Provider has been released which includes the fix for this :)

Thanks!

@pixelicous
Copy link

pixelicous commented Apr 26, 2018

@tombuildsstuff hey! i saw :) amazing, and just as i decided to implement the null_resource with a sleep 😄

kudos for the quick timeframe between 1.3.3 and 1.4 🔥 ❕

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure keyvault gets created but secret creation doesnt wait for availability, and crashes
4 participants