Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_netapp_volume - support the data_protection_replication block #10610

Merged
merged 30 commits into from
Feb 23, 2021

Conversation

paulomarquesc
Copy link
Contributor

This PR implements support for Cross-Region Replication (CRR) feature of ANF Volumes.

Worth it to call out that since CRR is extremely sensitive on resources being complete, we extended usage of stateCOnf.WaitForState for all steps of volume creation/deletion.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @paulomarquesc - overall this looks good, but i've left a couple comments inline that once addressed this should be good to merge 🚀

@paulomarquesc
Copy link
Contributor Author

Hi @katbyte , just pushed new commit to fix your comments and CI linting issues.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulomarquesc - i've left some more comments inline

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulomarquesc - aside from a few minor comments this LGTM now ! 👍

@paulomarquesc paulomarquesc reopened this Feb 23, 2021
@katbyte katbyte added this to the v2.49.0 milestone Feb 23, 2021
@paulomarquesc
Copy link
Contributor Author

Thanks Katie.

@katbyte katbyte changed the title Azure NetApp Files Cross-Region implementation azurerm_netapp_volume - support the data_protection_replication block Feb 23, 2021
@katbyte katbyte merged commit c24fb0e into hashicorp:master Feb 23, 2021
katbyte added a commit that referenced this pull request Feb 23, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants