Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb_backend_address_pool: mark backend_address as computed #10481

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 5, 2021

Fix the regression caused by #10291, that the associated NIC will be cleared by LB BAP

…ociated by `azurerm_lb_backend_address_pool`
@jackofallops
Copy link
Member

Tests passing:
image

@katbyte katbyte changed the title azurerm_lb_backend_address_pool: allow backend_address take NIC associated by azurerm_lb_backend_address_pool azurerm_lb_backend_address_pool: mark backend_address as computed Feb 5, 2021
@katbyte katbyte merged commit 0310e84 into hashicorp:master Feb 5, 2021
katbyte added a commit that referenced this pull request Feb 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.1 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.1"
}
# ... other configuration ...

tombuildsstuff added a commit that referenced this pull request Feb 5, 2021
Since this is only applicable to Standard SKU's, inlining this within the Backend Address Pool
resource ends up breaking this for Basic SKU users (the majority of LB's at this time). Whilst
PR #10481 fixed this by making this field Computed, this should have become a separate resource
rather than embedded within the Backend Address Pool - due to the limitations (where this is
only applicable for Standard SKU's).
@ghost
Copy link

ghost commented Mar 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants