Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for skip_metric_validation in azurerm_monitor_metric_alert #10422

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Feb 2, 2021

Fix #10421

=== RUN TestAccMonitorMetricAlert_basic
=== PAUSE TestAccMonitorMetricAlert_basic
=== CONT TestAccMonitorMetricAlert_basic
--- PASS: TestAccMonitorMetricAlert_basic (306.26s)
=== RUN TestAccMonitorMetricAlert_requiresImport
=== PAUSE TestAccMonitorMetricAlert_requiresImport
=== CONT TestAccMonitorMetricAlert_requiresImport
--- PASS: TestAccMonitorMetricAlert_requiresImport (329.54s)
=== RUN TestAccMonitorMetricAlert_complete
=== PAUSE TestAccMonitorMetricAlert_complete
=== CONT TestAccMonitorMetricAlert_complete
--- PASS: TestAccMonitorMetricAlert_complete (306.20s)
=== RUN TestAccMonitorMetricAlert_basicAndCompleteUpdate
=== PAUSE TestAccMonitorMetricAlert_basicAndCompleteUpdate
=== CONT TestAccMonitorMetricAlert_basicAndCompleteUpdate
--- PASS: TestAccMonitorMetricAlert_basicAndCompleteUpdate (747.31s)
=== RUN TestAccMonitorMetricAlert_multiScope
=== PAUSE TestAccMonitorMetricAlert_multiScope
=== CONT TestAccMonitorMetricAlert_multiScope
--- PASS: TestAccMonitorMetricAlert_multiScope (1170.62s)
=== RUN TestAccMonitorMetricAlert_applicationInsightsWebTest
=== PAUSE TestAccMonitorMetricAlert_applicationInsightsWebTest
=== CONT TestAccMonitorMetricAlert_applicationInsightsWebTest
--- PASS: TestAccMonitorMetricAlert_applicationInsightsWebTest (308.82s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte added this to the v2.46.0 milestone Feb 4, 2021
@katbyte katbyte merged commit 8b8bea5 into hashicorp:master Feb 4, 2021
katbyte added a commit that referenced this pull request Feb 4, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.46.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 6, 2021
@yupwei68 yupwei68 deleted the wyp-monitor-ma branch April 6, 2021 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for skipMetricValidation for azurerm_monitor_metric_alert
2 participants