Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for blobIndexMatch in azurerm_storage_management_policy #10400

Closed
wants to merge 9 commits into from

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Feb 1, 2021

Fix #10399

=== RUN TestAccStorageManagementPolicy_basic
=== PAUSE TestAccStorageManagementPolicy_basic
=== CONT TestAccStorageManagementPolicy_basic
--- PASS: TestAccStorageManagementPolicy_basic (150.54s)
=== RUN TestAccStorageManagementPolicy_singleAction
=== PAUSE TestAccStorageManagementPolicy_singleAction
=== CONT TestAccStorageManagementPolicy_singleAction
--- PASS: TestAccStorageManagementPolicy_singleAction (150.55s)
=== RUN TestAccStorageManagementPolicy_singleActionUpdate
=== PAUSE TestAccStorageManagementPolicy_singleActionUpdate
=== CONT TestAccStorageManagementPolicy_singleActionUpdate
--- PASS: TestAccStorageManagementPolicy_singleActionUpdate (205.12s)
=== RUN TestAccStorageManagementPolicy_multipleRule
=== PAUSE TestAccStorageManagementPolicy_multipleRule
=== CONT TestAccStorageManagementPolicy_multipleRule
--- PASS: TestAccStorageManagementPolicy_multipleRule (150.75s)
=== RUN TestAccStorageManagementPolicy_updateMultipleRule
=== PAUSE TestAccStorageManagementPolicy_updateMultipleRule
=== CONT TestAccStorageManagementPolicy_updateMultipleRule
--- PASS: TestAccStorageManagementPolicy_updateMultipleRule (205.35s)
=== RUN TestAccStorageManagementPolicy_blobTypes
=== PAUSE TestAccStorageManagementPolicy_blobTypes
=== CONT TestAccStorageManagementPolicy_blobTypes
--- PASS: TestAccStorageManagementPolicy_blobTypes (150.79s)
=== RUN TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== CONT TestAccStorageManagementPolicy_blobIndexMatch
--- PASS: TestAccStorageManagementPolicy_blobIndexMatch (305.72s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 -left some comments inline to address before merge

@yupwei68 yupwei68 requested a review from katbyte February 2, 2021 02:17
@yupwei68
Copy link
Contributor Author

yupwei68 commented Feb 2, 2021

Thanks @katbyte for your comments. Please continue reviewing.

@yupwei68
Copy link
Contributor Author

Thanks for your comments, Tom. Please continue reviewing.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 - this resource has a bunch of test failures in TC, can we fix them up first?:


TestAccDataSourceStorageManagementPolicy_basic
--
TestAccDataSourceStorageManagementPolicy_blobTypes
TestAccStorageManagementPolicy_basic
TestAccStorageManagementPolicy_blobTypes
TestAccStorageManagementPolicy_multipleRule
TestAccStorageManagementPolicy_singleAction
TestAccStorageManagementPolicy_singleActionUpdate
TestAccStorageManagementPolicy_updateMultipleRule
TestAccStorageManagementPolicy_blobIndexMatch

@yupwei68
Copy link
Contributor Author

Thanks kt. All tests have passed.

=== RUN TestAccStorageManagementPolicy_basic
=== PAUSE TestAccStorageManagementPolicy_basic
=== CONT TestAccStorageManagementPolicy_basic
--- PASS: TestAccStorageManagementPolicy_basic (148.92s)
=== RUN TestAccStorageManagementPolicy_singleAction
=== PAUSE TestAccStorageManagementPolicy_singleAction
=== CONT TestAccStorageManagementPolicy_singleAction
--- PASS: TestAccStorageManagementPolicy_singleAction (151.36s)
=== RUN TestAccStorageManagementPolicy_singleActionUpdate
=== PAUSE TestAccStorageManagementPolicy_singleActionUpdate
=== CONT TestAccStorageManagementPolicy_singleActionUpdate
--- PASS: TestAccStorageManagementPolicy_singleActionUpdate (204.51s)
=== RUN TestAccStorageManagementPolicy_multipleRule
=== PAUSE TestAccStorageManagementPolicy_multipleRule
=== CONT TestAccStorageManagementPolicy_multipleRule
--- PASS: TestAccStorageManagementPolicy_multipleRule (155.33s)
=== RUN TestAccStorageManagementPolicy_updateMultipleRule
=== PAUSE TestAccStorageManagementPolicy_updateMultipleRule
=== CONT TestAccStorageManagementPolicy_updateMultipleRule
--- PASS: TestAccStorageManagementPolicy_updateMultipleRule (205.73s)
=== RUN TestAccStorageManagementPolicy_blobTypes
=== PAUSE TestAccStorageManagementPolicy_blobTypes
=== CONT TestAccStorageManagementPolicy_blobTypes
--- PASS: TestAccStorageManagementPolicy_blobTypes (149.08s)
=== RUN TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== CONT TestAccStorageManagementPolicy_blobIndexMatch
--- PASS: TestAccStorageManagementPolicy_blobIndexMatch (305.73s)

=== RUN TestAccDataSourceStorageManagementPolicy_basic
=== PAUSE TestAccDataSourceStorageManagementPolicy_basic
=== CONT TestAccDataSourceStorageManagementPolicy_basic
--- PASS: TestAccDataSourceStorageManagementPolicy_basic (153.73s)
=== RUN TestAccDataSourceStorageManagementPolicy_blobTypes
=== PAUSE TestAccDataSourceStorageManagementPolicy_blobTypes
=== CONT TestAccDataSourceStorageManagementPolicy_blobTypes
--- PASS: TestAccDataSourceStorageManagementPolicy_blobTypes (152.87s)

@yupwei68 yupwei68 requested a review from katbyte March 25, 2021 01:54
@yupwei68
Copy link
Contributor Author

close for #11163

@yupwei68 yupwei68 closed this Mar 31, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
@yupwei68 yupwei68 deleted the wyp-storage-mp branch June 7, 2021 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for blobIndexMatch in azurerm_storage_management_policy
3 participants