Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamanalytics: switching to use a Resource ID Parser/Validator #10128

Merged
merged 10 commits into from
Jan 12, 2021

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 11, 2021

This PR generates the Resource ID Parsers/Validators for, and then switches the following resources over to using them:

  • azurerm_stream_analytics_function_javascript_udf
  • azurerm_stream_analytics_job
  • azurerm_stream_analytics_output_blob
  • azurerm_stream_analytics_output_eventhub
  • azurerm_stream_analytics_output_mssql
  • azurerm_stream_analytics_output_servicebus_queue
  • azurerm_stream_analytics_output_servicebus_topic

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2021-01-11 at 18 14 22

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 1a1fa48 into master Jan 12, 2021
@tombuildsstuff tombuildsstuff deleted the r/streamanalytics-parser branch January 12, 2021 11:02
@ghost
Copy link

ghost commented Jan 14, 2021

This has been released in version 2.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants