Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub_digital_twins -> azurerm_digital_twins_instance #9430

Merged
merged 5 commits into from
Nov 25, 2020

Conversation

WodansSon
Copy link
Collaborator

Fixing PR Comment left on #9212

@WodansSon
Copy link
Collaborator Author

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

ctx, cancel := timeouts.ForCreate(meta.(*clients.Client).StopContext, d)
defer cancel()

name := d.Get("name").(string)
resourceGroup := d.Get("resource_group_name").(string)

id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we format this here:

Suggested change
id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name)
id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name).ID("")

}
}
if existing.ID != nil && *existing.ID != "" {
return tf.ImportAsExistsError("azurerm_iothub_digital_twins", *existing.ID)
return tf.ImportAsExistsError("azurerm_digital_twins_instance", *existing.ID)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can then use that here:

Suggested change
}
if !utils.ResponseWasNotFound(existing.Response) {
return tf.ImportAsExistsError("azurerm_digital_twins_instance", id)
}

id, err := parse.DigitalTwinsID(*resp.ID)
if err != nil {
return err
}
d.SetId(id.ID(subscriptionId))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll be removing this subscriptionId field - so whilst this isn't technically an issue - we may as well switch this out for an empty string early since we're making another change here (it's provided on the constructor above now)

Suggested change
d.SetId(id.ID(subscriptionId))
d.SetId(id.ID(""))

@WodansSon WodansSon merged commit cee2562 into master Nov 25, 2020
@tombuildsstuff tombuildsstuff deleted the u_digitalTwinsRename branch November 25, 2020 09:00
WodansSon added a commit that referenced this pull request Nov 25, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants