Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster incorrect diff due to casing on addon_profile.oms_agent.log_analytics_workspace_id #9151

Closed
schuettecarsten opened this issue Nov 4, 2020 · 5 comments · Fixed by #9976

Comments

@schuettecarsten
Copy link

The following update on property addon_profile.oms_agent.log_analytics_workspace_id for a azurerm_kubernetes_cluster resource is unneccessary because only the casing is different:

~ log_analytics_workspace_id = "/subscriptions/b55149b2-2597-4455-b224-5159c38e1a2f/resourceGroups/abc-shared/providers/Microsoft.OperationalInsights/workspaces/abc-workspace-f17310012a04c444" -> "/subscriptions/b55149b2-2597-4455-b224-5159c38e1a2f/resourcegroups/abc-shared/providers/microsoft.operationalinsights/workspaces/abc-workspace-f17310012a04c444"

Using terraform 0.13.5 and azurerm provider 2.34.0.

@yene
Copy link

yene commented Dec 21, 2020

Same in version azurerm = "=2.41.0"

blaw2422 added a commit to blaw2422/terraform-provider-azurerm that referenced this issue Dec 21, 2020
@blaw2422
Copy link

@schuettecarsten , I was having the same problem. I tested this locally and it is working for me. I've never opened a PR into this repo so I'm not sure what I should do next, but am waiting for guidance.

blaw2422 added a commit to blaw2422/terraform-provider-azurerm that referenced this issue Dec 21, 2020
@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
katbyte pushed a commit that referenced this issue Jan 5, 2021
…ensure correct casing (#9976)

Instead of changing casing back as #9967 proposes, parse the ID in oms_addon by using the same parsers, to fix #9151
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@anhlqn
Copy link

anhlqn commented Jan 12, 2021

I've tested upgrading to v2.42.0 and still run into this issue. Below is the terraform plan output. I'm on terraform 0.13.4.

Initializing provider plugins...
- Finding hashicorp/azuread versions matching "~> 0.11.0"...
- Finding hashicorp/azurerm versions matching "~> 2.42.0"...
- Installing hashicorp/azuread v0.11.0...
- Installed hashicorp/azuread v0.11.0 (signed by HashiCorp)
- Installing hashicorp/azurerm v2.42.0...
- Installed hashicorp/azurerm v2.42.0 (signed by HashiCorp)

[...]
~ oms_agent {
                enabled                    = true
              ~ log_analytics_workspace_id = "/subscriptions/<redacted>/resourceGroups/<redacted>/providers/Microsoft.OperationalInsights/workspaces/<redacted>" -> "/subscriptions/<redacted>/resourcegroups/<redacted>/providers/microsoft.operationalinsights/workspaces/<redacted>"

@ghost
Copy link

ghost commented Feb 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.