Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_managed_disk - Ultra Disk logical Sector size feature #8965

Closed
PadreGregor opened this issue Oct 21, 2020 · 2 comments · Fixed by #13637
Closed

azurerm_managed_disk - Ultra Disk logical Sector size feature #8965

PadreGregor opened this issue Oct 21, 2020 · 2 comments · Fixed by #13637
Labels
enhancement service/disks
Milestone
v2.80.0

Comments

@PadreGregor
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

https://docs.microsoft.com/en-us/rest/api/compute/disks/createorupdate#creationdata
We would like to set the logicalSectorSize. If you click on the link it is available under the Creation Data body.

New or Affected Resource(s)

  • azurerm_managed_disk

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Oct 6, 2021
@favoretti
r/azurerm_managed_disk: Add support for logical_sector_size property
1298d5e 
Fixes hashicorp#8965

$ TF_ACC=1 go test -v ./internal/services/compute -timeout=1000m -run='TestAccAzureRMManagedDisk_create_withLogicalSectorSize|TestAccAzureRMManagedDisk_update_withMaxShares'
=== RUN   TestAccAzureRMManagedDisk_update_withMaxShares
=== PAUSE TestAccAzureRMManagedDisk_update_withMaxShares
=== RUN   TestAccAzureRMManagedDisk_create_withLogicalSectorSize
=== PAUSE TestAccAzureRMManagedDisk_create_withLogicalSectorSize
=== CONT  TestAccAzureRMManagedDisk_update_withMaxShares
=== CONT  TestAccAzureRMManagedDisk_create_withLogicalSectorSize
--- PASS: TestAccAzureRMManagedDisk_create_withLogicalSectorSize (134.52s)
--- PASS: TestAccAzureRMManagedDisk_update_withMaxShares (176.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/compute	177.465s

2nd acceptance test ran to be sure I haven't introduced a regression.
@favoretti favoretti mentioned this issue Oct 6, 2021
Merged
@katbyte katbyte added this to the v2.80.0 milestone Oct 6, 2021
katbyte pushed a commit that referenced this issue Oct 6, 2021
@favoretti
r/azurerm_managed_disk: Add support for logical_sector_size prope…
d7b313e 
…rty (#13637)

Fixes #8965
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement service/disks
Projects
None yet
Milestone
v2.80.0
3 participants
@tombuildsstuff @katbyte @PadreGregor