azurerm_storage_account: adding support for account_kind being StorageV2
#851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2017-10-01 removed a lot of Context parameters from API calls, so sadly they had to be removed in order for this to compile. - In addition, the storage account Create api uses a cancel-channel instead of a context, so this update passes in the ctx.Done() channel so that at least these operations can be cancelled. - One good thing in this new version is that the Create API returns an account on a channel, so that the additional call to GetProperties is unnecessary to retrieve the account id
- Add StorageV2 to account_kind validation - Allow access_tier to be set on StorageV2 kinds
tombuildsstuff
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
hey @justenwalker
Thanks for this PR - I've taken a look through and this LGTM 👍 I'll kick off the test suite now
Thanks!
|
Ignoring some known Azure issues (storage encryption is becoming required) - the tests pass:
Thanks again for this PR :) |
tombuildsstuff
changed the title
azurerm_storage_account: adding support for account_kind being StorageV2
tombuildsstuff
added a commit
that referenced
this pull request
Feb 19, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806
This PR adds support for
account_kind = "StorageV2"inazurerm_storage_accountIn order to achieve this, the Storage API was upgraded to
2017-10-01and changes needed to be made to make the management API calls consistent with the new call signatures.Specifically: