Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support for Minimum TLS Version for Azure Storage Account #7778

Closed
eedwards36 opened this issue Jul 16, 2020 · 2 comments · Fixed by #7879
Closed

Feature Request: Support for Minimum TLS Version for Azure Storage Account #7778

eedwards36 opened this issue Jul 16, 2020 · 2 comments · Fixed by #7879

Comments

@eedwards36
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Minimum TLS version can now be set for Azure Storage Accounts. When deploying from Terraform the minimum TLS version defaults to Version 1.0.

The property doesn't appear in the latest ARM template https://docs.microsoft.com/en-us/azure/templates/microsoft.storage/storageaccounts, but when you export the template from the portal there is the property 'minimumTLSVersion' which can be set accordingly.
https://stackoverflow.com/questions/62870673/azure-storageaccount-minimum-tls1-2-support

New or Affected Resource(s)

azurerm_storage_account

Potential Terraform Configuration

resource "azurerm_storage_account" "example" {
  name                     = "storageaccountname"
  resource_group_name      = azurerm_resource_group.example.name
  location                 = azurerm_resource_group.example.location
  account_tier             = "Standard"
  account_replication_type = "GRS"
  minimum_tls_version  = "TLS1_2"

  tags = {
    environment = "staging"
  }
}

References

  • #0000
@eedwards36 eedwards36 changed the title Feature Request: Minimum TLS Version for Azure Storage Account Support for [thing] Feature Request: Minimum TLS Version for Azure Storage Account Support for Jul 16, 2020
@eedwards36 eedwards36 changed the title Feature Request: Minimum TLS Version for Azure Storage Account Support for Feature Request: Support for Minimum TLS Version for Azure Storage Account Jul 16, 2020
@magodo magodo added this to the v2.22.0 milestone Aug 4, 2020
magodo pushed a commit that referenced this issue Aug 6, 2020
set the `min_tls_version` when creating a storage account.

This closes #7778, closes #7966.
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 2.22.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.22.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants