Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for autoscale for HDInsight clusters #6470

Closed
kosinsky opened this issue Apr 14, 2020 · 4 comments
Closed

Support for autoscale for HDInsight clusters #6470

kosinsky opened this issue Apr 14, 2020 · 4 comments

Comments

@kosinsky
Copy link
Contributor

kosinsky commented Apr 14, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

HDInsight clusters support autoscale feature. Cluster could be scaled based on load (capacity) or schedule. Only worker nodes could be autoscaled

Autoscale can be set during creation via ARM: https://docs.microsoft.com/en-us/azure/templates/microsoft.hdinsight/2018-06-01-preview/clusters#autoscale-object and

Autoscale can be enabled or disabled via REST API: https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-autoscale-clusters#using-the-rest-api
https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-autoscale-clusters#create-a-cluster-with-a-resource-manager-template

New or Affected Resource(s)

  • azurerm_hdinsight_(hadoop|hbase|spark|interactive_query)_cluster

Potential Terraform Configuration

Capacity based

resource "azurerm_hdinsight_hadoop_cluster" "example" {
  name                = "example-hdicluster"
  resource_group_name = "${azurerm_resource_group.example.name}"
  location            = "${azurerm_resource_group.example.location}"
  cluster_version     = "3.6"
  tier                = "Standard"

 roles {
     head_node {
        // ...
     }
     worker_node {
       vm_size               = "Standard_D3_V2"
       username              = "acctestusrvm"
       password              = var.role_password
       target_instance_count = 2
       autoscale  {
            capacity {
               min_instance_count = 2
               max_instance_count = 3
            }
       }
     }
     zookeeper_node {
        // ...

     }
   }
}

Schedule based

resource "azurerm_hdinsight_hadoop_cluster" "example" {
  name                = "example-hdicluster"
  resource_group_name = "${azurerm_resource_group.example.name}"
  location            = "${azurerm_resource_group.example.location}"
  cluster_version     = "3.6"
  tier                = "Standard"

 roles {
     head_node {
        // ...
     }
     worker_node {
       vm_size               = "Standard_D3_V2"
       username              = "acctestusrvm"
       password              = var.role_password
       target_instance_count = 2
       autoscale  {
           recurrence {
            timezone  = "Pacific Standard Time"
              schedule {
                days      = ["Monday"]
                time      = "10:00"
                min_instance_count = 5
                max_instance_count = 5    
              }            
              schedule {
                days      = ["Saturday", "Sunday"]
                time      = "10:00"
                min_instance_count = 2
                max_instance_count = 2                
              }
            }
       }
     }
     zookeeper_node {
        // ...

     }
   }

}
@kosinsky kosinsky changed the title Support for minimum autoscale for HDInisght clusters Support for autoscale for HDInisght clusters Apr 14, 2020
@tombuildsstuff tombuildsstuff changed the title Support for autoscale for HDInisght clusters Support for autoscale for HDInsight clusters Apr 15, 2020
@kosinsky
Copy link
Contributor Author

REST API has been supporting update Autoscale for a while now. However, it was added to Go SDK only in v44.2.0 https://github.com/Azure/azure-sdk-for-go/pull/11841/files#diff-eb83effee75e9070818d473dc7064433

Looks like 44.2.0 update is pretty minor one (Azure/azure-sdk-for-go#11841) hope we will get it pretty soon

katbyte pushed a commit that referenced this issue Jul 31, 2020
#7933)

Updating Azure SDK for Go to v44.2.0 to support #6470
It's pretty minor update with additions only https://github.com/Azure/azure-sdk-for-go/pull/11841/files
We are vendoring only HDInsight parts of 44.2.0 update

cc @jackofallops @ArcturusZhang
@mbfrahry mbfrahry added this to the v2.58.0 milestone May 3, 2021
@katbyte katbyte modified the milestones: v2.58.0, v2.59.0, v2.60.0 May 7, 2021
@katbyte katbyte modified the milestones: v2.60.0, v2.61.0 May 20, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.61.0, v2.62.0 May 27, 2021
@katbyte katbyte modified the milestones: v2.62.0, v2.63.0 Jun 4, 2021
@katbyte katbyte modified the milestones: v2.63.0, v2.64.0 Jun 11, 2021
@katbyte katbyte modified the milestones: v2.64.0, v2.65.0 Jun 18, 2021
@tombuildsstuff tombuildsstuff modified the milestones: v2.65.0, v2.66.0 Jun 25, 2021
@jackofallops
Copy link
Member

Closing as this appears to have been resolved in #11547

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This functionality has been released in v2.66.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants