Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for spot node pool in azurerm_kubernetes_cluster #6086

Closed
huangyingting opened this issue Mar 12, 2020 · 6 comments · Fixed by #7233
Closed

Support for spot node pool in azurerm_kubernetes_cluster #6086

huangyingting opened this issue Mar 12, 2020 · 6 comments · Fixed by #7233
Assignees
Labels
enhancement preview sdk/requires-newer-api-version This requires upgrading the version of the API being used service/kubernetes-cluster
Milestone

Comments

@huangyingting
Copy link

huangyingting commented Mar 12, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Request to support for spot node pool in azurerm_kubernetes_cluster

Request to support for spot node pool in azurerm_kubernetes_cluster as per article in below
https://docs.microsoft.com/en-us/azure/aks/spot-node-pool

  • azurerm_kubernetes_cluster

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
rajalokan added a commit to rajalokan/terraform-provider-azurerm that referenced this issue Mar 23, 2020
- Support for spot node pool in azurerm_kubernetes_cluster

Fixes hashicorp#6086
@rajalokan
Copy link

I've raise a PR for this above. I tried but this isn't working for me. Must be missing something simple.

  • Running this using make build and using that binary
  • After doing similar changes, I was able to add a new nodepool. But new node added wasn't a spot node. I think scale_set_priority should be priority .
  • Unfortunatily I didn't save those changes.
  • Now when I try, it fails with
Error: Can not parse "priority" as a resource id: Cannot parse Azure ID: parse "spot": invalid URI for request

Point me to changes and I would love to get this done urgently. Thanks.

@tombuildsstuff tombuildsstuff added this to the v2.6.0 milestone Apr 8, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.6.0, v2.7.0 Apr 16, 2020
tombuildsstuff pushed a commit that referenced this issue Apr 17, 2020
- Support for spot node pool in azurerm_kubernetes_cluster

Fixes #6086
@katbyte katbyte modified the milestones: v2.7.0, v2.8.0 Apr 23, 2020
@katbyte katbyte modified the milestones: v2.8.0, v2.9.0 Apr 30, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.9.0, v2.11.0 May 7, 2020
@4c74356b41
Copy link

hey, i'd really like to get this moving, anything I can do to help push this?

@tombuildsstuff tombuildsstuff modified the milestones: v2.11.0, v2.12.0 May 19, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.12.0, v2.13.0 May 27, 2020
@tombuildsstuff tombuildsstuff self-assigned this May 27, 2020
@tombuildsstuff tombuildsstuff added the sdk/requires-newer-api-version This requires upgrading the version of the API being used label May 29, 2020
pbrit added a commit to pbrit/terraform-provider-azurerm that referenced this issue May 31, 2020
* Support of Spot Priority for `azurerm_kubernetes_cluster_node_pool`
* `node_taints` and `node_labels` were marked as computed and
  they must force a pool recreation.

The initial work was started as hashicorp#6231

Fixes hashicorp#6086

Co-Authored-By: Alok Kumar <[email protected]>
pbrit added a commit to pbrit/terraform-provider-azurerm that referenced this issue May 31, 2020
* Support of Spot Priority for `azurerm_kubernetes_cluster_node_pool`
* `node_taints` and `node_labels` were marked as computed and
  they must force a pool recreation.

The initial work was started as hashicorp#6231

Fixes hashicorp#6086

Co-Authored-By: Alok Kumar <[email protected]>
pbrit added a commit to pbrit/terraform-provider-azurerm that referenced this issue May 31, 2020
* Support of Spot Priority for `azurerm_kubernetes_cluster_node_pool`
* `node_taints` and `node_labels` were marked as *computed* and they must force a pool recreation.

The initial work was started as hashicorp#6231

Fixes hashicorp#6086

Co-Authored-By: Alok Kumar <[email protected]>
@pbrit
Copy link

pbrit commented May 31, 2020

@4c74356b41 Please have a look at #7145.

pbrit added a commit to pbrit/terraform-provider-azurerm that referenced this issue May 31, 2020
* Support of Spot Priority for `azurerm_kubernetes_cluster_node_pool`
* `node_taints` and `node_labels` were marked as *computed* and they must force a pool recreation.

The initial work was started as hashicorp#6231

Fixes hashicorp#6086

Co-Authored-By: Alok Kumar <[email protected]>
@4c74356b41
Copy link

I'm afraid I dont really know how terraform is working, so its hard for me to be of value, but I can test the result, or, perhaps, if you need some help on the azure side, I could do that

pbrit added a commit to pbrit/terraform-provider-azurerm that referenced this issue Jun 4, 2020
* Support of Spot Priority for `azurerm_kubernetes_cluster_node_pool`
* `node_taints` and `node_labels` were marked as *computed* and they must force a new pool resource
* Add `max_bid_price` validation for `windows_virtual_machine_scale_set`
   and `linux_virtual_machine_scale_set`

The initial work was started as hashicorp#6231

Fixes hashicorp#6086

Co-Authored-By: Alok Kumar <[email protected]>
@tombuildsstuff tombuildsstuff modified the milestones: v2.13.0, v2.14.0 Jun 4, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.