Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_redis_cache - Primary connection string attribute #5856

Closed
robinmanuelthiel opened this issue Feb 24, 2020 · 4 comments
Closed

Comments

@robinmanuelthiel
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In contrast to the Azure Portal, azurerm_redis_cache does not expose a Primary connection string attribute. My use case would be to directly inject the connection string into Azure Key Vault.

image

Please be aware, that this Primary connection string seems to be specifically dedicated to the StackExchange.Redis .NET library, so let's consider that vendor-specific attribute for the discussion!

My current workaround is building this connection string by myself:

resource "azurerm_key_vault_secret" "redis_cache_connection_string" {
  name         = "RedisCacheConnectionString"
  value        = "${azurerm_redis_cache.default.hostname}:${azurerm_redis_cache.default.ssl_port},password=${azurerm_redis_cache.default.primary_access_key},ssl=True,abortConnect=False"
  key_vault_id = azurerm_key_vault.default.id
}

New or Affected Resource(s)

  • azurerm_redis_cache
# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@jackbatzner
Copy link
Contributor

I am working on this at the moment, will get a PR out early next week! Want to make sure I have the formatting correct before pushing.

jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this issue Mar 2, 2020
…ction_string' to 'resource_arm_redis_cache' resource and data source

Resource Acceptance Tests:
=== RUN   TestAccDataSourceAzureRMRedisCache_standard
=== PAUSE TestAccDataSourceAzureRMRedisCache_standard
=== CONT  TestAccDataSourceAzureRMRedisCache_standard
--- PASS: TestAccDataSourceAzureRMRedisCache_standard (2127.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 2127.824s
katbyte added a commit that referenced this issue Mar 4, 2020
* #5856 - Add 'primary_connection_string' and 'secondary_connection_string' to 'resource_arm_redis_cache' resource and data source

Resource Acceptance Tests:
=== RUN   TestAccDataSourceAzureRMRedisCache_standard
=== PAUSE TestAccDataSourceAzureRMRedisCache_standard
=== CONT  TestAccDataSourceAzureRMRedisCache_standard
--- PASS: TestAccDataSourceAzureRMRedisCache_standard (2127.56s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 2127.824s

* Fix linting issue
@tombuildsstuff tombuildsstuff added this to the v2.1.0 milestone Mar 9, 2020
@tombuildsstuff
Copy link
Contributor

Fixed via #5958

@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants