-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_sql_server
- support for the extended_auditing_policy
property
#5036
Conversation
continuation of #4755 |
Hi @tombuildsstuff , thanks for your comments. I have replied them in #4755. I have made the corresponding changes in this PR and DB PR #5049. Please review |
hi @tombuildsstuff , any problem? |
…form-provider-azurerm into wyp-sqlserverauditing
…form-provider-azurerm into wyp-sqlserverauditing
Hi @katbyte Thanks! Corresponding changes are pushed. I'll update sql database auditing after this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @yupwei68, we're getting this close, left a couple more comments inline
Hi @katbyte Sure! Once merged, I shall update 'extending_auditing' for sql_db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yupwei68, this is real close now with just a couple minor comments left that need to be addressed before merge
* `storage_endpoint` - (Required) Specifies the blob storage endpoint (e.g. https://MyAccount.blob.core.windows.net). | ||
|
||
* `storage_account_access_key_is_secondary` - (Optional) Specifies whether `storage_account_access_key` value is the storage's secondary key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we order these alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need to put required
fields in advance? We just order all required
and optional
fields alphabetically, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WHoops missed the optional, yes typically alphabetically, but sometimes i'll order for aesthetics ie storage_endpoint
-> storage_account_access_key
-> storage_account_access_key_is_secondary
"storage_endpoint": { | ||
Type: schema.TypeString, | ||
Required: true, | ||
ValidateFunc: validate.URLIsHTTPS, | ||
}, | ||
|
||
"storage_account_access_key_is_secondary": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we order these alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same concern. So we don't need to put required fields in advance? We just order all required and optional fields alphabetically, right?
Hi @katbyte , some concerns of the last two comments are left. Looking forward to get this PR merged!^ ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the change @yupwei68! LGTM now 👍
blob_extended_auditing_policy
in resource: resource_arm_sql_server
azurerm_sql_server
- support for the extended_auditing_policy
property
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
1.To add block code
blob_extended_auditing_policy
inresource_arm_sql_server
to permit blob auditing policy stored in storage account.blob_auditing_policy
are all inclusive inblob_extended_auditing_policy
. Andblob_extended_auditing_policy
has one more featurepredicate_expression
3.
is_storage_secondary_key_in_use
is available on portal(show as belows), so I have reserved this feature.Fixes #2217
2020.3.5