Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob metadata #3206

Merged
merged 8 commits into from
Apr 9, 2019
Merged

Blob metadata #3206

merged 8 commits into from
Apr 9, 2019

Conversation

Lucretius
Copy link
Contributor

Resolves #1400

  • Added support for metadata property for storage blobs
  • Updated markdown by adding property
  • Added metadata to basic test (if desired, I can split this into a separate test for metadata, but seeing as metadata is like a tag it looks like we normally just include those in basic tests)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lucretius,

thank you for the PR! aside from a couple minor comments i've left inline this LGTM

azurerm/resource_arm_storage_blob.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_blob.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_blob.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_blob.go Show resolved Hide resolved
@Lucretius
Copy link
Contributor Author

Thanks @katbyte for the feedback, I've renamed the functions as desired.

@ghost ghost removed the waiting-response label Apr 8, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lucretius! LGTM now 👍

katbyte added a commit that referenced this pull request Apr 9, 2019
@katbyte katbyte merged commit e6fbb47 into hashicorp:master Apr 9, 2019
@Lucretius Lucretius deleted the blob_metadata branch April 9, 2019 20:44
@bpoland
Copy link

bpoland commented Apr 9, 2019

Thanks everyone!

@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for blob metadata
4 participants