Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_subnet should have its gateway IP as an exported attribute #21

Open
hashibot opened this issue Jun 13, 2017 · 2 comments
Open

Comments

@hashibot
Copy link

This issue was originally opened by @wendorf as hashicorp/terraform#9519. It was migrated here as part of the provider split. The original body of the issue is below.


According to the [Azure virtual network documentation], the gateway IP address of a subnet is predictable (e.g. if the subnet is 10.0.3.0/24, the gateway IP is 10.0.3.1). It is as simple as cidrhost(azurerm_subnet.my_subnet.address_prefix, 1).

It would be nice if this information were part of the built-in exported attributes for azurerm_subnets so that users of the resource can easily determine what the Gateway is without needing to do calculations.

Terraform Version

0.7.7

Affected Resource(s)

  • azurerm_subnet

Expected Behavior

The resource knows its own gateway IP

Actual Behavior

The resource does not know its gateway IP

apparentlymart pushed a commit that referenced this issue Jul 22, 2017
…ion (#14341)

* initial commit - 101-vm-from-user-image

* changed branch name

* not deploying - storage problems

* provisions vm but image not properly prepared

* storage not correct

* provisions properly

* changed main.tf to azuredeploy.tf

* added tfvars and info for README

* tfvars ignored and corrected file ext

* added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing

* deploy.sh to be executable

* executable deploy files

* added CI files; changed vars

* prep for PR

* removal of old folder

* prep for PR

* wrong args for travis

* more PR prep

* updated README

* commented out variables in terraform.tfvars

* Topic 101 vm from user image (#2)

* initial commit - 101-vm-from-user-image
* added tfvars and info for README
* added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing
* prep for PR

* added new template

* oops, left off master

* prep for PR

* correct repository for destination

* renamed scripts to be more intuitive; added check for docker

* merge vm simple; vm from image

* initial commit

* deploys locally

* updated deploy

* consolidated deploy and after_deploy into a single script; simplified ci process; added os_profile_linux_config

* added terraform show

* initial commit

* changed to allow http & https (like ARM tmplt)

* changed host_name & host_name variable desc

* added az cli check

* on this branch, only build test_dir; master will aggregate all the examples

* deploys locally; need to fix deploy scripts

* chmod for deploy.ci.sh

* corrected deploy.ci.sh

* added resource group var to travis.yml

* merge master

* edited travis.yml

* fixed error on travis.yml

* added new constructs/naming for deploy scripts, etc.

* took rg variable out; added destroy resources to travis.yml

* cleaned up commented out lines in deploy.ci.sh

* suppress az login output

* suppress az login output

* forgot about line breaks

* breaking build as an example

* fixing broken build example

* merge of CI config

* prep for PR

* cleanup for PR

* fixed grammar in readme

* prep for PR

* took out armviz button and minor README changes

* changed host_name

* fixed merge conflicts

* changed host_name variable

* updating Hashicorp's changes to merged simple linux branch

* updating files to merge w/master and prep for Hashicorp pr

* Revert "updating files to merge w/master and prep for Hashicorp pr"

This reverts commit b850cd5d2a858eff073fc5a1097a6813d0f8b362.

* Revert "updating Hashicorp's changes to merged simple linux branch"

This reverts commit dbaf8d14a9cdfcef0281919671357f6171ebd4e6.

* removing vm from user image example from this branch

* removed old branch

* added depends_on resource group for workaround to bug

* resolving conflicts

* restoring previous examples/resolving merge conflict

* resolving conflict

* updated .travis.yml

* azure-2-vms-loadbalancer-lbrules (#13)

* initial commit

* need to change lb_rule & nic

* deploys locally

* updated README

* updated travis and deploy scripts for Hari's repo

* renamed deploy script

* clean up

* prep for PR

* updated readme

* fixing conflict in .travis.yml

* add CI build tag

* updated descriptions

* azure-traffic-manager-vm (#17)

adding example of azure traffic manager

* azure-vnet-to-vnet-peering (#20)

adding vnet-to-vnet-peering example

* returning .travis.yml to correct state

* azure-search-create (#21)

adding azure-search-create example

* merging Hashicorp master into this branch

* added graph to README

* removing unmerged examples
@rcarun rcarun added this to the M1 milestone Oct 12, 2017
@tombuildsstuff tombuildsstuff modified the milestones: M1, Future Oct 16, 2017
@tombuildsstuff tombuildsstuff removed the M1 label Oct 16, 2017
@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Oct 16, 2017

Reading through the original issue I'd agree that this belongs on the Virtual Network Gateway resource - rather than on the Subnet resource. As such I'm parking this until the Virtual Network Gateway API's fixed and we can proceed with that resource.

@tombuildsstuff tombuildsstuff changed the title provider/azurerm azurerm_subnet should have its gateway IP as an exported attribute azurerm_subnet should have its gateway IP as an exported attribute Feb 22, 2018
@tombuildsstuff tombuildsstuff removed this from the Future milestone Feb 22, 2018
@katbyte katbyte removed the upstream label May 17, 2018
@katbyte katbyte added this to the 1.6.0 milestone May 17, 2018
@tombuildsstuff tombuildsstuff self-assigned this May 17, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.6.0, 1.7.0 May 24, 2018
@tombuildsstuff tombuildsstuff removed their assignment Jun 1, 2018
@katbyte katbyte added the upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR label Jun 12, 2018
@katbyte katbyte modified the milestones: 1.7.0, Future Jun 12, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Future, Being Sorted Oct 25, 2018
@tombuildsstuff tombuildsstuff added good first issue and removed upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Oct 25, 2018
@tombuildsstuff tombuildsstuff removed this from the Being Sorted milestone Oct 25, 2018
@favoretti
Copy link
Collaborator

Since the OP wants the default gateway IP address that's pre-defined by Azure and is unrelated to VNET Gateways (one can have subnets that do not have such a thing, yet have a default gateway) - I don't think VNET Gateway is the right place to implement the request.

That said, since currently subnets can have multiple address prefixes and in any case the API doesn't return anything remotely resembling default gateway IP - I propose we close the issue, since Azure docs clearly states how to calculate default gateway's IP and terraform core makes it fairly easy and it would be trivial nor fail-proof to add that calculation to the provider.

@tombuildsstuff thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants