Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servicebus: Update SDK to 2021-06-01-preview #13701

Merged

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 12, 2021

Required for at least #13514 and #9740

Acceptance tests

I just ran a random test to verify the basics are working, which seems to be the case:

❯ go install && make acctests SERVICE='servicebus' TESTARGS='-run=TestAccServiceBusTopic_update'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/servicebus -run=TestAccServiceBusTopic_update -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccServiceBusTopic_update
=== PAUSE TestAccServiceBusTopic_update
=== CONT  TestAccServiceBusTopic_update
--- PASS: TestAccServiceBusTopic_update (382.31s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    383.856s

@aristosvo aristosvo changed the title servicebus: Update API to 2021-06-01-preview servicebus: Update SDK to 2021-06-01-preview Oct 13, 2021
@aristosvo aristosvo force-pushed the servicebus/update-api-to-2021-06-01-preview branch 4 times, most recently from 850622c to 5ab751f Compare October 15, 2021 06:59
@aristosvo aristosvo marked this pull request as ready for review October 15, 2021 07:05
@aristosvo aristosvo force-pushed the servicebus/update-api-to-2021-06-01-preview branch from 5ab751f to ff632e1 Compare October 15, 2021 14:04
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM 🏗️

@katbyte katbyte added this to the v2.82.0 milestone Oct 15, 2021
@katbyte katbyte merged commit 5692cde into hashicorp:main Oct 15, 2021
katbyte added a commit that referenced this pull request Oct 15, 2021
katbyte pushed a commit that referenced this pull request Oct 21, 2021
…01-preview` (#13760)

I was not aware of the multiple API versions used in the servicebus, and just moved 2017-04-01 to 2021-06-01-preview in #13701.

The other half of the job 😭
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants