Skip to content

Commit

Permalink
Enum changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Aris van Ommeren committed Oct 15, 2021
1 parent 2257baa commit 5ab751f
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 33 deletions.
18 changes: 9 additions & 9 deletions internal/services/servicebus/internal.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ func expandAuthorizationRuleRights(d *pluginsdk.ResourceData) *[]servicebus.Acce
rights := make([]servicebus.AccessRights, 0)

if d.Get("listen").(bool) {
rights = append(rights, servicebus.Listen)
rights = append(rights, servicebus.AccessRightsListen)
}

if d.Get("send").(bool) {
rights = append(rights, servicebus.SendEnumValue)
rights = append(rights, servicebus.AccessRightsSend)
}

if d.Get("manage").(bool) {
rights = append(rights, servicebus.Manage)
rights = append(rights, servicebus.AccessRightsManage)
}

return &rights
Expand All @@ -37,11 +37,11 @@ func flattenAuthorizationRuleRights(rights *[]servicebus.AccessRights) (listen,
if rights != nil {
for _, right := range *rights {
switch right {
case servicebus.Listen:
case servicebus.AccessRightsListen:
listen = true
case servicebus.SendEnumValue:
case servicebus.AccessRightsSend:
send = true
case servicebus.Manage:
case servicebus.AccessRightsManage:
manage = true
default:
log.Printf("[DEBUG] Unknown Authorization Rule Right '%s'", right)
Expand Down Expand Up @@ -148,8 +148,8 @@ func waitForPairedNamespaceReplication(ctx context.Context, meta interface{}, re
aliasName := *disasterRecoveryResponse.Values()[0].Name

stateConf := &pluginsdk.StateChangeConf{
Pending: []string{string(servicebus.Accepted)},
Target: []string{string(servicebus.Succeeded)},
Pending: []string{string(servicebus.ProvisioningStateDRAccepted)},
Target: []string{string(servicebus.ProvisioningStateDRSucceeded)},
MinTimeout: 30 * time.Second,
Timeout: timeout,
Refresh: func() (interface{}, string, error) {
Expand All @@ -159,7 +159,7 @@ func waitForPairedNamespaceReplication(ctx context.Context, meta interface{}, re
}

if props := read.ArmDisasterRecoveryProperties; props != nil {
if props.ProvisioningState == servicebus.Failed {
if props.ProvisioningState == servicebus.ProvisioningStateDRFailed {
return read, "failed", fmt.Errorf("replication for Service Bus Namespace Disaster Recovery Configs %q (Namespace %q / Resource Group %q) failed", aliasName, namespaceName, resourceGroup)
}
return read, string(props.ProvisioningState), nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,8 @@ func resourceServiceBusNamespaceDisasterRecoveryConfigDelete(d *pluginsdk.Resour

func resourceServiceBusNamespaceDisasterRecoveryConfigWaitForState(ctx context.Context, client *servicebus.DisasterRecoveryConfigsClient, resourceGroup, namespaceName, name string, timeout time.Duration) error {
stateConf := &pluginsdk.StateChangeConf{
Pending: []string{string(servicebus.Accepted)},
Target: []string{string(servicebus.Succeeded)},
Pending: []string{string(servicebus.ProvisioningStateDRAccepted)},
Target: []string{string(servicebus.ProvisioningStateDRSucceeded)},
MinTimeout: 30 * time.Second,
Timeout: timeout,
Refresh: func() (interface{}, string, error) {
Expand All @@ -311,7 +311,7 @@ func resourceServiceBusNamespaceDisasterRecoveryConfigWaitForState(ctx context.C
}

if props := read.ArmDisasterRecoveryProperties; props != nil {
if props.ProvisioningState == servicebus.Failed {
if props.ProvisioningState == servicebus.ProvisioningStateDRFailed {
return read, "failed", fmt.Errorf("replication for Service Bus Namespace Disaster Recovery Configs %q (Namespace %q / Resource Group %q) failed", name, namespaceName, resourceGroup)
}
return read, string(props.ProvisioningState), nil
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func dataSourceServiceBusQueueRead(d *pluginsdk.ResourceData, meta interface{})
return err
}

if namespace.Sku.Name != servicebus.Premium {
if namespace.Sku.Name != servicebus.SkuNamePremium {
const partitionCount = 16
maxSizeInMegabytes = int(*apiMaxSizeInMegabytes / partitionCount)
}
Expand Down
22 changes: 11 additions & 11 deletions internal/services/servicebus/servicebus_queue_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,16 @@ func resourceServiceBusQueue() *pluginsdk.Resource {
"status": {
Type: pluginsdk.TypeString,
Optional: true,
Default: string(servicebus.Active),
Default: string(servicebus.EntityStatusActive),
ValidateFunc: validation.StringInSlice([]string{
string(servicebus.Active),
string(servicebus.Creating),
string(servicebus.Deleting),
string(servicebus.Disabled),
string(servicebus.ReceiveDisabled),
string(servicebus.Renaming),
string(servicebus.SendDisabled),
string(servicebus.Unknown),
string(servicebus.EntityStatusActive),
string(servicebus.EntityStatusCreating),
string(servicebus.EntityStatusDeleting),
string(servicebus.EntityStatusDisabled),
string(servicebus.EntityStatusReceiveDisabled),
string(servicebus.EntityStatusRenaming),
string(servicebus.EntityStatusSendDisabled),
string(servicebus.EntityStatusUnknown),
}, false),
},
},
Expand Down Expand Up @@ -247,7 +247,7 @@ func resourceServiceBusQueueCreateUpdate(d *pluginsdk.ResourceData, meta interfa

// Enforce Premium namespace to have Express Entities disabled in Terraform since they are not supported for
// Premium SKU.
if namespace.Sku.Name == servicebus.Premium && d.Get("enable_express").(bool) {
if namespace.Sku.Name == servicebus.SkuNamePremium && d.Get("enable_express").(bool) {
return fmt.Errorf("ServiceBus Queue %q does not support Express Entities in Premium SKU and must be disabled", resourceId.Name)
}

Expand Down Expand Up @@ -310,7 +310,7 @@ func resourceServiceBusQueueRead(d *pluginsdk.ResourceData, meta interface{}) er
return err
}

if namespace.Sku.Name != servicebus.Premium {
if namespace.Sku.Name != servicebus.SkuNamePremium {
const partitionCount = 16
maxSizeInMegabytes = int(*apiMaxSizeInMegabytes / partitionCount)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ func resourceServiceBusSubscription() *pluginsdk.Resource {
"status": {
Type: pluginsdk.TypeString,
Optional: true,
Default: string(servicebus.Active),
Default: string(servicebus.EntityStatusActive),
ValidateFunc: validation.StringInSlice([]string{
string(servicebus.Active),
string(servicebus.Disabled),
string(servicebus.ReceiveDisabled),
string(servicebus.EntityStatusActive),
string(servicebus.EntityStatusDisabled),
string(servicebus.EntityStatusReceiveDisabled),
}, false),
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func dataSourceServiceBusTopicRead(d *pluginsdk.ResourceData, meta interface{})
return err
}

if namespace.Sku.Name != servicebus.Premium {
if namespace.Sku.Name != servicebus.SkuNamePremium {
const partitionCount = 16
maxSize = int(*props.MaxSizeInMegabytes / partitionCount)
}
Expand Down
8 changes: 4 additions & 4 deletions internal/services/servicebus/servicebus_topic_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ func resourceServiceBusTopic() *pluginsdk.Resource {
"status": {
Type: pluginsdk.TypeString,
Optional: true,
Default: string(servicebus.Active),
Default: string(servicebus.EntityStatusActive),
ValidateFunc: validation.StringInSlice([]string{
string(servicebus.Active),
string(servicebus.Disabled),
string(servicebus.EntityStatusActive),
string(servicebus.EntityStatusDisabled),
}, true),
DiffSuppressFunc: suppress.CaseDifference,
},
Expand Down Expand Up @@ -237,7 +237,7 @@ func resourceServiceBusTopicRead(d *pluginsdk.ResourceData, meta interface{}) er
return err
}

if namespace.Sku.Name != servicebus.Premium {
if namespace.Sku.Name != servicebus.SkuNamePremium {
const partitionCount = 16
maxSize = int(*props.MaxSizeInMegabytes / partitionCount)
}
Expand Down

0 comments on commit 5ab751f

Please sign in to comment.