r/azurerm_managed_disk: Add support for logical_sector_size property
#13637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hashicorp#8965 $ TF_ACC=1 go test -v ./internal/services/compute -timeout=1000m -run='TestAccAzureRMManagedDisk_create_withLogicalSectorSize|TestAccAzureRMManagedDisk_update_withMaxShares' === RUN TestAccAzureRMManagedDisk_update_withMaxShares === PAUSE TestAccAzureRMManagedDisk_update_withMaxShares === RUN TestAccAzureRMManagedDisk_create_withLogicalSectorSize === PAUSE TestAccAzureRMManagedDisk_create_withLogicalSectorSize === CONT TestAccAzureRMManagedDisk_update_withMaxShares === CONT TestAccAzureRMManagedDisk_create_withLogicalSectorSize --- PASS: TestAccAzureRMManagedDisk_create_withLogicalSectorSize (134.52s) --- PASS: TestAccAzureRMManagedDisk_update_withMaxShares (176.08s) PASS ok github.com/hashicorp/terraform-provider-azurerm/internal/services/compute 177.465s 2nd acceptance test ran to be sure I haven't introduced a regression.
katbyte
approved these changes
Oct 6, 2021
katbyte
added a commit
that referenced
this pull request
Oct 6, 2021
|
This functionality has been released in v2.80.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8965
$ TF_ACC=1 go test -v ./internal/services/compute -timeout=1000m -run='TestAccAzureRMManagedDisk_create_withLogicalSectorSize|TestAccAzureRMManagedDisk_update_withMaxShares'
=== RUN TestAccAzureRMManagedDisk_update_withMaxShares
=== PAUSE TestAccAzureRMManagedDisk_update_withMaxShares
=== RUN TestAccAzureRMManagedDisk_create_withLogicalSectorSize
=== PAUSE TestAccAzureRMManagedDisk_create_withLogicalSectorSize
=== CONT TestAccAzureRMManagedDisk_update_withMaxShares
=== CONT TestAccAzureRMManagedDisk_create_withLogicalSectorSize
--- PASS: TestAccAzureRMManagedDisk_create_withLogicalSectorSize (134.52s)
--- PASS: TestAccAzureRMManagedDisk_update_withMaxShares (176.08s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/compute 177.465s
2nd acceptance test ran to be sure I haven't introduced a regression.