-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820
Conversation
Signed-off-by: xuzhang3 <Zhangxu894765>
@@ -73,6 +73,14 @@ The following arguments are supported: | |||
|
|||
~> **Note:** Configuring the number of replicas per master is only available when using the Premium SKU and cannot be used in conjunction with shards. | |||
|
|||
* `replicas_per_primary` - (Optional) Amount of replicas to create per primary for this Redis Cache. If both `replicas_per_primary` and `replicas_per_master` are set, they need to be equal. | |||
|
|||
* `redis_version` - (Optional) Redis version. Only major version needed. Valid values: `4`, `6`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's optional, what is the default value ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its computed so its derived from the API (and can change depending on what azure defaults too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BzSpi For current API, the default value will be 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xuzhang3 - LGTM ❄️
@@ -73,6 +73,14 @@ The following arguments are supported: | |||
|
|||
~> **Note:** Configuring the number of replicas per master is only available when using the Premium SKU and cannot be used in conjunction with shards. | |||
|
|||
* `replicas_per_primary` - (Optional) Amount of replicas to create per primary for this Redis Cache. If both `replicas_per_primary` and `replicas_per_master` are set, they need to be equal. | |||
|
|||
* `redis_version` - (Optional) Redis version. Only major version needed. Valid values: `4`, `6`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its computed so its derived from the API (and can change depending on what azure defaults too)
This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Redis Cache enhancemnent:
redisVersion
,tenantSettings
,replicasPerPrimary
2020-06-01
to2020-12-01
AccTest: