Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/redis_cache: Add support for Redis 6 #9403

Closed
andrei-dascalu opened this issue Nov 19, 2020 · 10 comments
Closed

r/redis_cache: Add support for Redis 6 #9403

andrei-dascalu opened this issue Nov 19, 2020 · 10 comments

Comments

@andrei-dascalu
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently in Azure there is the possibility of choosing either Redis 4 or Redis 6 (preview). As of now azurerm_redis_cache doesn't seem to have an option to make a choice.

New or Affected Resource(s)

azurerm_redis_cache
azurerm_redis_linked_server (presumably?)

Potential Terraform Configuration

Not sure about where this could go, whether this would be a redis_configuration item or a simple version key

Thanks!

@maxkuzkin
Copy link

maxkuzkin commented Feb 16, 2021

I would suggest changing the title of this issue to "Add support for Redis 6", because, practically speaking, it's not possible to use Redis 6 in Azure through Terraform without this feature today.

And even though Redis 6 Preview has been announced by Microsoft back in November (https://azure.microsoft.com/en-us/updates/redis-60-is-now-in-preview-for-azure-cache-for-redis/), all of us who automate our deployments (which is the target audience of services like Redis, most likely) are currently not able to use Redis 6 in our scenarios.

Combined with the fact that there is no Redis 5 support in Azure, this is an issue for usu which needs to be fixed with high priority, because we're stuck with Redis 4 only.

@tombuildsstuff tombuildsstuff changed the title Support for Azure Cache for Redis version selection r/redis_cache: support for Redis 6 Feb 17, 2021
@tombuildsstuff
Copy link
Contributor

👋

Taking a look through here it appears there's a couple of different things to call out here:

  1. Support for Azure Redis Cache running v6 of Redis appears to be possible by setting "redisVersion": "6" within the properties block - however support for this isn't available in the Azure SDK at this point (only as a read-only value). As such this'd need Microsoft to support this within the Azure SDK for us to be able to support this in Terraform - @WodansSon would you mind running that down?
  2. Support for Azure Redis Enterprise Cache - which does include support for Redis 6 in the SDK - however this looks to be an entirely separate service

Whilst this issue is tracking the former - and so at this point is blocked on the Azure SDK adding support for this - if you're looking for support for Redis Enterprise, please open a separate Feature Request so that we can track that specifically.

Thanks!

@tombuildsstuff tombuildsstuff added sdk/not-yet-supported Support for this does not exist in the upstream SDK at this time sdk/requires-swagger-changes Changes need to be made in the Swagger specifications to enable this functionality upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Feb 17, 2021
@NillsF
Copy link
Contributor

NillsF commented Feb 26, 2021

@tombuildsstuff @WodansSon: I believe the issue is not (only) an SDK issue, but a raw API issue for Redis. Based on what I'm seeing in the API documentation, the redisVersion property is not available as a property in the body on the create request and only is available on the returned object.

@andrei-dascalu andrei-dascalu changed the title r/redis_cache: support for Redis 6 r/redis_cache: Add support for Redis 6 Feb 27, 2021
@steph-moto
Copy link

Has there been any updates on this. I truly believe it would be beneficial to have this supported from terraform

@tomatwoodliquidx
Copy link

Any status update on this item?

@Poil
Copy link

Poil commented Aug 3, 2021

Hi,

The SDK have been updated to support API 2020-1201.
We just need a patch to support the "version" parameter

Best regards

@Poil
Copy link

Poil commented Aug 4, 2021

#12820

@tombuildsstuff
Copy link
Contributor

Fixed via #12820

@tombuildsstuff tombuildsstuff added this to the v2.71.0 milestone Aug 5, 2021
@tombuildsstuff tombuildsstuff removed sdk/not-yet-supported Support for this does not exist in the upstream SDK at this time sdk/requires-swagger-changes Changes need to be made in the Swagger specifications to enable this functionality upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants