Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_healthcare_service: support for customer managed key #11481

Merged
merged 9 commits into from
Apr 29, 2021
Merged

azurerm_healthcare_service: support for customer managed key #11481

merged 9 commits into from
Apr 29, 2021

Conversation

b4rd
Copy link
Contributor

@b4rd b4rd commented Apr 26, 2021

This PR adds CMK support for azurerm_healthcare_service.

Reference document: https://docs.microsoft.com/en-in/azure/healthcare-apis/fhir/customer-managed-key

Fixes: #10632

Test Results

TF_ACC=1 go test -v ./azurerm/internal/services/healthcare  -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/27 12:58:43 [DEBUG] not using binary driver name, it's no longer needed
2021/04/27 12:58:43 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHealthCareServiceDataSource_basic
=== PAUSE TestAccHealthCareServiceDataSource_basic
=== RUN   TestAccHealthCareServiceDataSource_complete
=== PAUSE TestAccHealthCareServiceDataSource_complete
=== RUN   TestAccHealthCareService_basic
=== PAUSE TestAccHealthCareService_basic
=== RUN   TestAccHealthCareService_requiresImport
=== PAUSE TestAccHealthCareService_requiresImport
=== RUN   TestAccHealthCareService_complete
=== PAUSE TestAccHealthCareService_complete
=== CONT  TestAccHealthCareServiceDataSource_basic
=== CONT  TestAccHealthCareService_requiresImport
=== CONT  TestAccHealthCareService_complete
=== CONT  TestAccHealthCareService_basic
=== CONT  TestAccHealthCareServiceDataSource_complete
--- PASS: TestAccHealthCareServiceDataSource_basic (1112.86s)
--- PASS: TestAccHealthCareService_basic (1115.46s)
--- PASS: TestAccHealthCareService_requiresImport (1189.59s)
--- PASS: TestAccHealthCareServiceDataSource_complete (1219.64s)
--- PASS: TestAccHealthCareService_complete (1223.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/healthcare  1224.166s

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @b4rd, thanks for the PR! This is off to a great start, the main issue with the proposed implementation is that it removes an existing property which is considered a breaking change. Whilst we can look to adjust the schema in such a way in a major version bump, such changes can't be included in a regular (minor) release. I've made a suggestion inline, if you can restore the original property and add the new one alongside it then I'll be happy to review again.

@katbyte katbyte added this to the v2.57.0 milestone Apr 28, 2021
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b4rd Thanks for making the changes! This is looking great, I have made a couple of suggestions inline below and committed them. Pending test results, this should be good to merge 👍

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results

Screenshot 2021-04-29 at 13 47 54

@manicminer manicminer merged commit 3e2b2c0 into hashicorp:master Apr 29, 2021
manicminer added a commit that referenced this pull request Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for customer managed key setting for azurerm_healthcare_service
3 participants