-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_healthcare_service: support for customer managed key #11481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @b4rd, thanks for the PR! This is off to a great start, the main issue with the proposed implementation is that it removes an existing property which is considered a breaking change. Whilst we can look to adjust the schema in such a way in a major version bump, such changes can't be included in a regular (minor) release. I've made a suggestion inline, if you can restore the original property and add the new one alongside it then I'll be happy to review again.
azurerm/internal/services/healthcare/healthcare_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/healthcare/healthcare_service_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/healthcare/healthcare_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/healthcare/healthcare_service_data_source.go
Outdated
Show resolved
Hide resolved
…sdb_key_vault_key_versionless_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b4rd Thanks for making the changes! This is looking great, I have made a couple of suggestions inline below and committed them. Pending test results, this should be good to merge 👍
azurerm/internal/services/healthcare/healthcare_service_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/healthcare/healthcare_service_data_source_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/healthcare/healthcare_service_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds CMK support for
azurerm_healthcare_service
.Reference document: https://docs.microsoft.com/en-in/azure/healthcare-apis/fhir/customer-managed-key
Fixes: #10632
Test Results