Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for customer managed key setting for azurerm_healthcare_service #10632

Closed
sven-hoffmann opened this issue Feb 18, 2021 · 2 comments · Fixed by #11481
Closed

Support for customer managed key setting for azurerm_healthcare_service #10632

sven-hoffmann opened this issue Feb 18, 2021 · 2 comments · Fixed by #11481
Milestone

Comments

@sven-hoffmann
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure API for FHIR now supports the usage of customer managed keys for encyrption at rest in its configuration. This new setting is currently not available in terraform. The concrete example for ARM templates (or other ways) can be found at the official documentation site: https://docs.microsoft.com/en-in/azure/healthcare-apis/customer-managed-key#using-azure-resource-manager-template

Concretely, here's a reduced example:

{
            "type": "Microsoft.HealthcareApis/services",
            "apiVersion": "2020-03-30",
            <snip>
            "properties": {
                <snip>
                "cosmosDbConfiguration": {
                    "offerThroughput": 400,
                    "keyVaultKeyUri": "https://<my-vault>.vault.azure.net/keys/<my-key>"
                },
               <snip>
            }
        }

New or Affected Resource(s)

  • azurerm_healthcare_service

Potential Terraform Configuration

I could imagine either:

resource "azurerm_healthcare_service" "example" {
  name                = "uniquefhirname"
  resource_group_name = "sample-resource-group"
  location            = "westus2"
  kind                = "fhir-R4"
  cosmosdb_throughput = "2000"
  cosmosdb_keyVaultKeyUri = "https://<my-vault>.vault.azure.net/keys/<my-key>"
}

Or this:

resource "azurerm_healthcare_service" "example" {
  name                = "uniquefhirname"
  resource_group_name = "sample-resource-group"
  location            = "westus2"
  kind                = "fhir-R4"
  cosmosdb_configuration = {
    throughput = "2000"
    keyVaultKeyUri = "https://<my-vault>.vault.azure.net/keys/<my-key>"
  }
}

I'm leaning towards the second option but the first one is backwards compatible and a non-breaking change.

References

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants