New resource azurerm_virtual_machine_configuration_policy_assignment

[ArcturusZhang]

This is a reopen of PR #10748
Guest Configuration is to audit settings inside a virtual machine, the validation can validate the settings such like:

• The configuration of the operating system
• Application configuration or presence
• Environment settings
  For more information, please refer to the doc page here: https://docs.microsoft.com/en-us/azure/governance/policy/concepts/guest-configuration

[ArcturusZhang]

Tests are passing on my local machine:

=== RUN   TestAccVirtualMachineConfigurationPolicyAssignment_basic
=== PAUSE TestAccVirtualMachineConfigurationPolicyAssignment_basic
=== CONT  TestAccVirtualMachineConfigurationPolicyAssignment_basic
--- PASS: TestAccVirtualMachineConfigurationPolicyAssignment_basic (436.20s)
=== RUN   TestAccVirtualMachineConfigurationPolicyAssignment_requiresImport
=== PAUSE TestAccVirtualMachineConfigurationPolicyAssignment_requiresImport
=== CONT  TestAccVirtualMachineConfigurationPolicyAssignment_requiresImport
--- PASS: TestAccVirtualMachineConfigurationPolicyAssignment_requiresImport (447.81s)
PASS

[ArcturusZhang]

The CI failure might be able to be fixed by https://github.com/terraform-providers/terraform-provider-azurerm/pull/11335/files

[katbyte]

Sorry if that was addressed in the old pr, i looked but did see it: there is assignment in the name yet the policy is inlined? does that mean this would make more sense as

Suggested change

	"azurerm_virtual_machine_configuration_policy_assignment": resourceVirtualMachineConfigurationPolicyAssignment(),
	"azurerm_virtual_machine_configuration_policy": resourceVirtualMachineConfigurationPolicyAssignment(),

[ArcturusZhang]

My thought on this resource name is that we need to emphasize that this is an assignment like azurerm_policy_assignment - creation of this resource will make the policy enabled on the target, therefore I kept the word "assignment" in the resource name. With the assignment, this resource reads like a policy definition
Therefore I suggest we keep the word assignment in the resource name, despite it might be long

[ArcturusZhang]

Hey @katbyte I have resolved the comments, please take a look, thank you!

[katbyte]

LGTM 👍

[ghost]

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.