-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_lb_backend_address_pool_address
#10488
Conversation
Since this is only applicable to Standard SKU's, inlining this within the Backend Address Pool resource ends up breaking this for Basic SKU users (the majority of LB's at this time). Whilst PR #10481 fixed this by making this field Computed, this should have become a separate resource rather than embedded within the Backend Address Pool - due to the limitations (where this is only applicable for Standard SKU's).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tombuildsstuff I've walked through this PR and left some comments, otherwise it LGTM 👍
azurerm/internal/services/loadbalancer/backend_address_pool_address_resource.go
Show resolved
Hide resolved
azurerm/internal/services/loadbalancer/backend_address_pool_address_resource_test.go
Show resolved
Hide resolved
Would it be possible for this resource to accept a list of IP addresses? Without that, it will require more instances of this resource to be created and managed. |
I guess there would be complexity around mapping an IP to the correct instance of the resource - but I don't know the internals to know if this is an issue. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dismissing since changes have been pushed
This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.47.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR introduces the new resource
azurerm_lb_backend_address_pool_address
- and force-deprecates the fieldbackend_addresses
within theazurerm_backend_address_pool
resource, since this is only applicable when using a Standard Load Balancer.Whilst nesting this within the
azurerm_backend_address_pool
does make sense in some circumstances - since these are additive (when a VM/VMSS is appended to the Backend Addresses list, this likely makes more sense as a separate resource, rather than making this Optional & Computed (as done in #10481) which, whilst works around this issue for Basic SKU's makes this harder to clear.This PR force-deprecates the
backend_addresses
field added to theazurerm_backend_address_pool
resource in #10291 - by ignoring the expanded value and setting the flattened value to an empty list to deprecate this field - to migrate people across.