Skip to content

Commit

Permalink
minor PR fixups for merge
Browse files Browse the repository at this point in the history
  • Loading branch information
jackofallops committed Apr 23, 2020
1 parent 1f07e3f commit d205114
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ func TestSpringCloudAppID(t *testing.T) {
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.AppPlatform/Spring/spring1/Apps/app1",
Expected: nil,
},
{
Name: "invalid app name Casing",
Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resGroup1/providers/Microsoft.AppPlatform/Spring/spring1/Apps/App1",
Expected: nil,
},
}

for _, v := range testData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func resourceArmSpringCloudApp() *schema.Resource {
return &schema.Resource{
Create: resourceArmSpringCloudAppCreate,
Read: resourceArmSpringCloudAppRead,
Update: nil,
Delete: resourceArmSpringCloudAppDelete,

Importer: azSchema.ValidateResourceIDPriorToImport(func(id string) error {
Expand Down Expand Up @@ -67,7 +66,7 @@ func resourceArmSpringCloudAppCreate(d *schema.ResourceData, meta interface{}) e
existing, err := client.Get(ctx, resourceGroup, serviceName, name, "")
if err != nil {
if !utils.ResponseWasNotFound(existing.Response) {
return fmt.Errorf("checking for present of existing Spring Cloud App %q (Spring Cloud Service %q / Resource Group %q): %+v", name, serviceName, resourceGroup, err)
return fmt.Errorf("checking for presence of existing Spring Cloud App %q (Spring Cloud Service %q / Resource Group %q): %+v", name, serviceName, resourceGroup, err)
}
}
if existing.ID != nil && *existing.ID != "" {
Expand Down

0 comments on commit d205114

Please sign in to comment.