Skip to content

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Dec 5, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
  • The resources and data sources in this provider are generated from the CloudFormation schema, so they can only support the actions that the underlying schema supports. For this reason submitted bugs should be limited to defects in the generation and runtime code of the provider. Customizing behavior of the resource, or noting a gap in behavior are not valid bugs and should be submitted as enhancements to AWS via the CloudFormation Open Coverage Roadmap.

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

CloudFormation schema updates as of 4 December 2025

% make smoke
make: Running smoke tests...
make: NOTE: All tests should pass. Error output for sdk.proto, "Response contains error diagnostic" can be ignored.
TF_ACC=1 go test ./internal/aws/logs -v -count 1 -parallel 3 -run=TestAccAWSLogsLogGroup_\|TestAccAWSLogsLogGroupDataSource_ -timeout 180m
=== RUN   TestAccAWSLogsLogGroup_basic
=== PAUSE TestAccAWSLogsLogGroup_basic
=== RUN   TestAccAWSLogsLogGroup_disappears
=== PAUSE TestAccAWSLogsLogGroup_disappears
=== RUN   TestAccAWSLogsLogGroup_update
=== PAUSE TestAccAWSLogsLogGroup_update
=== RUN   TestAccAWSLogsLogGroupDataSource_basic
=== PAUSE TestAccAWSLogsLogGroupDataSource_basic
=== RUN   TestAccAWSLogsLogGroupDataSource_NonExistent
=== PAUSE TestAccAWSLogsLogGroupDataSource_NonExistent
=== CONT  TestAccAWSLogsLogGroup_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_basic
=== CONT  TestAccAWSLogsLogGroupDataSource_NonExistent
2025-12-04T19:37:11.524-0800 [ERROR] sdk.proto: Response contains error diagnostic: tf_rpc=ReadDataSource diagnostic_detail="After attempting to read the data source, the API returned a resource not found error for the id provided. Original Error: couldn't find resource" diagnostic_severity=ERROR diagnostic_summary="AWS Data Source Not Found" tf_provider_addr=registry.terraform.io/hashicorp/awscc tf_req_id=a6952669-5feb-3bca-d352-032af4f57aca tf_proto_version=6.10 tf_data_source_type=awscc_logs_log_group
--- PASS: TestAccAWSLogsLogGroupDataSource_NonExistent (2.28s)
=== CONT  TestAccAWSLogsLogGroup_update
--- PASS: TestAccAWSLogsLogGroupDataSource_basic (29.00s)
=== CONT  TestAccAWSLogsLogGroup_disappears
--- PASS: TestAccAWSLogsLogGroup_basic (29.74s)
--- PASS: TestAccAWSLogsLogGroup_update (43.72s)
--- PASS: TestAccAWSLogsLogGroup_disappears (32.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-awscc/internal/aws/logs	62.199s

Relates #2914

@gdavison gdavison requested a review from a team as a code owner December 5, 2025 03:50
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 49ccc19 into main Dec 5, 2025
33 checks passed
@gdavison gdavison deleted the 2025-12-04-schema-updates branch December 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants