Skip to content

resource/aws_instance: Adding support for Root Device Encryption#9107

Closed
stack72 wants to merge 1 commit intohashicorp:masterfrom
stack72:stack72/root-volume-encryption
Closed

resource/aws_instance: Adding support for Root Device Encryption#9107
stack72 wants to merge 1 commit intohashicorp:masterfrom
stack72:stack72/root-volume-encryption

Conversation

@stack72
Copy link
Copy Markdown
Contributor

@stack72 stack72 commented Jun 24, 2019

As released https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/

▶ acctests aws TestAccAWSInstance_encryptedRootDevice
=== RUN   TestAccAWSInstance_encryptedRootDevice
=== PAUSE TestAccAWSInstance_encryptedRootDevice
=== CONT  TestAccAWSInstance_encryptedRootDevice
--- PASS: TestAccAWSInstance_encryptedRootDevice (161.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	161.229s

As released https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/

```
▶ acctests aws TestAccAWSInstance_encryptedRootDevice
=== RUN   TestAccAWSInstance_encryptedRootDevice
=== PAUSE TestAccAWSInstance_encryptedRootDevice
=== CONT  TestAccAWSInstance_encryptedRootDevice
--- PASS: TestAccAWSInstance_encryptedRootDevice (161.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	161.229s
```
@stack72 stack72 requested a review from a team June 24, 2019 17:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 24, 2019
@bflad
Copy link
Copy Markdown
Contributor

bflad commented Jul 2, 2019

Hi @stack72 👋 Thanks for working on this. Part of this pull request currently duplicates changes in pull request #7757 so it'll likely require a rebase when the earlier one is merged in. I think we'd happily get this in though if it was just the data source changes. Sorry for the trouble. 😖

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 2, 2019
@stack72
Copy link
Copy Markdown
Contributor Author

stack72 commented Jul 2, 2019

Hey @bflad

I’m happy to go with what you think here - just let me know what you want me to do

Paul

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 2, 2019
@stack72
Copy link
Copy Markdown
Contributor Author

stack72 commented Jul 31, 2019

Closing out in favour of #7757

@stack72 stack72 closed this Jul 31, 2019
@stack72 stack72 deleted the stack72/root-volume-encryption branch July 31, 2019 14:06
@ghost
Copy link
Copy Markdown

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants