New data sources: aws_route53_resolver_rule and aws_route53_resolver_rules

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8508.

Release note for CHANGELOG:

- New Data Source:  aws_route53_resolver_rule
- New Data Source:  aws_route53_resolver_rules

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsRoute53ResolverRule_ -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (41.30s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (252.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	252.604s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRules_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsRoute53ResolverRules_ -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (20.62s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (257.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	257.496s

[ewbankkit]

Related:

• d/aws_route53_resolver_endpoint: Add Route53resolver endpoint datasource #8628

[ewbankkit]

TODO:

• Add aws_route53_resolver_rules data source

[ewbankkit]

Removed WIP.
Ready for review.

[ewbankkit]

Rebased to fix merge conflict.

[nywilken]

Hi @ewbankkit thanks for putting together these data sources. This is looking good. I left a few minor suggestions along with some output around a failing test case that only occurs when running all data source tests in parallel. Please take a look and let me know if you have any questions or if you no longer have bandwidth to work on this PR.

[ewbankkit]

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsRoute53ResolverRule_ -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (41.96s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (274.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	274.855s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRules_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsRoute53ResolverRules_ -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (16.98s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (428.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	428.186s

[ewbankkit]

@nywilken All review comments addressed.

[nywilken]

hi @ewbankkit sorry for the delayed turn around on this PR. I was still running into issues when running the tests for both data sources in parallel.

make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsRoute53ResolverRule'

I went ahead and fixed the test by changing the route53 resolver rule type in one of the test configurations to get it passing. I will merge this in and we can look to revisit the test if you think it no longer reflects your initial intent.

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsRoute53ResolverRule -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== PAUSE TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_basic
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_basic
=== RUN   TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== PAUSE TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId
=== CONT  TestAccDataSourceAwsRoute53ResolverRules_basic
=== CONT  TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (18.07s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (42.41s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (220.82s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (220.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       221.002s

[nywilken]

Merged manually with additional commits.

[ghost]

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!