-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Managed Instances on Amazon ECS #44509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSCapacityProvider_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 feat/ecs_managed_instances 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSCapacityProvider_ -timeout 360m -vet=off
2025/10/01 10:29:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 10:29:55 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccECSCapacityProvider_Identity_Basic
=== PAUSE TestAccECSCapacityProvider_Identity_Basic
=== RUN TestAccECSCapacityProvider_Identity_RegionOverride
=== PAUSE TestAccECSCapacityProvider_Identity_RegionOverride
=== RUN TestAccECSCapacityProvider_Identity_ExistingResource
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource
=== RUN TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== RUN TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN TestAccECSCapacityProvider_clusterFieldValidations
=== PAUSE TestAccECSCapacityProvider_clusterFieldValidations
=== RUN TestAccECSCapacityProvider_mutualExclusivity
=== PAUSE TestAccECSCapacityProvider_mutualExclusivity
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== RUN TestAccECSCapacityProvider_updateManagedInstancesProvider
=== PAUSE TestAccECSCapacityProvider_updateManagedInstancesProvider
=== CONT TestAccECSCapacityProvider_Identity_Basic
=== CONT TestAccECSCapacityProvider_tags
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements (37.46s)
=== CONT TestAccECSCapacityProvider_mutualExclusivity
--- PASS: TestAccECSCapacityProvider_mutualExclusivity (2.49s)
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_basic
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_basic (34.96s)
=== CONT TestAccECSCapacityProvider_clusterFieldValidations
--- PASS: TestAccECSCapacityProvider_clusterFieldValidations (2.43s)
=== CONT TestAccECSCapacityProvider_updateManagedInstancesProvider
--- PASS: TestAccECSCapacityProvider_updateManagedInstancesProvider (51.87s)
=== CONT TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_Identity_Basic (136.68s)
=== CONT TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_tags (216.19s)
=== CONT TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_basic (92.65s)
=== CONT TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (96.97s)
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration (36.33s)
=== CONT TestAccECSCapacityProvider_Identity_ExistingResource
--- PASS: TestAccECSCapacityProvider_disappears (73.20s)
=== CONT TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccECSCapacityProvider_managedScaling (188.14s)
=== CONT TestAccECSCapacityProvider_Identity_RegionOverride
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange (142.86s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource (218.86s)
--- PASS: TestAccECSCapacityProvider_Identity_RegionOverride (127.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 537.881s
? github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures [no test files]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% make t T=TestAccECSCapacityProvider_ K=ecs P=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 feat/ecs_managed_instances 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ecs/... -v -count 1 -parallel 3 -run='TestAccECSCapacityProvider_' -timeout 360m -vet=off
2025/10/01 11:56:32 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 11:56:32 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccECSCapacityProvider_Identity_Basic
=== PAUSE TestAccECSCapacityProvider_Identity_Basic
=== RUN TestAccECSCapacityProvider_Identity_RegionOverride
=== PAUSE TestAccECSCapacityProvider_Identity_RegionOverride
=== RUN TestAccECSCapacityProvider_Identity_ExistingResource
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource
=== RUN TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== RUN TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN TestAccECSCapacityProvider_clusterFieldValidations
=== PAUSE TestAccECSCapacityProvider_clusterFieldValidations
=== RUN TestAccECSCapacityProvider_mutualExclusivity
=== PAUSE TestAccECSCapacityProvider_mutualExclusivity
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== RUN TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== RUN TestAccECSCapacityProvider_updateManagedInstancesProvider
=== PAUSE TestAccECSCapacityProvider_updateManagedInstancesProvider
=== CONT TestAccECSCapacityProvider_Identity_Basic
=== CONT TestAccECSCapacityProvider_tags
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements (38.12s)
=== CONT TestAccECSCapacityProvider_updateManagedInstancesProvider
--- PASS: TestAccECSCapacityProvider_tags (54.58s)
=== CONT TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_Identity_Basic (55.27s)
=== CONT TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_updateManagedInstancesProvider (51.41s)
=== CONT TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_basic (35.48s)
=== CONT TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (44.11s)
=== CONT TestAccECSCapacityProvider_mutualExclusivity
--- PASS: TestAccECSCapacityProvider_mutualExclusivity (2.32s)
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_basic
--- PASS: TestAccECSCapacityProvider_disappears (26.48s)
=== CONT TestAccECSCapacityProvider_clusterFieldValidations
--- PASS: TestAccECSCapacityProvider_clusterFieldValidations (2.26s)
=== CONT TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_basic (38.81s)
=== CONT TestAccECSCapacityProvider_Identity_ExistingResource
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration (36.92s)
=== CONT TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccECSCapacityProvider_managedScaling (67.26s)
=== CONT TestAccECSCapacityProvider_Identity_RegionOverride
--- PASS: TestAccECSCapacityProvider_Identity_RegionOverride (53.01s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource (86.29s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange (71.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 232.522s
? github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures [no test files]|
@kg-aws Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds support for Managed Instances on Amazon ECS.
Relations
Closes #44511.
Relates https://github.com/aws-ecs-bdx/private-ecs-terraform-provider-aws/pull/132.
Output from Acceptance Testing