Skip to content

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 30, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds support for Managed Instances on Amazon ECS.

Relations

Closes #44511.
Relates https://github.com/aws-ecs-bdx/private-ecs-terraform-provider-aws/pull/132.

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@ewbankkit ewbankkit requested a review from a team as a code owner September 30, 2025 20:31
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels Sep 30, 2025
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 1, 2025
Copy link
Contributor Author

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSCapacityProvider_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 feat/ecs_managed_instances 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSCapacityProvider_ -timeout 360m -vet=off
2025/10/01 10:29:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 10:29:55 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccECSCapacityProvider_Identity_Basic
=== PAUSE TestAccECSCapacityProvider_Identity_Basic
=== RUN   TestAccECSCapacityProvider_Identity_RegionOverride
=== PAUSE TestAccECSCapacityProvider_Identity_RegionOverride
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSCapacityProvider_clusterFieldValidations
=== PAUSE TestAccECSCapacityProvider_clusterFieldValidations
=== RUN   TestAccECSCapacityProvider_mutualExclusivity
=== PAUSE TestAccECSCapacityProvider_mutualExclusivity
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== RUN   TestAccECSCapacityProvider_updateManagedInstancesProvider
=== PAUSE TestAccECSCapacityProvider_updateManagedInstancesProvider
=== CONT  TestAccECSCapacityProvider_Identity_Basic
=== CONT  TestAccECSCapacityProvider_tags
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements (37.46s)
=== CONT  TestAccECSCapacityProvider_mutualExclusivity
--- PASS: TestAccECSCapacityProvider_mutualExclusivity (2.49s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_basic
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_basic (34.96s)
=== CONT  TestAccECSCapacityProvider_clusterFieldValidations
--- PASS: TestAccECSCapacityProvider_clusterFieldValidations (2.43s)
=== CONT  TestAccECSCapacityProvider_updateManagedInstancesProvider
--- PASS: TestAccECSCapacityProvider_updateManagedInstancesProvider (51.87s)
=== CONT  TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_Identity_Basic (136.68s)
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_tags (216.19s)
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_basic (92.65s)
=== CONT  TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (96.97s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration (36.33s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource
--- PASS: TestAccECSCapacityProvider_disappears (73.20s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccECSCapacityProvider_managedScaling (188.14s)
=== CONT  TestAccECSCapacityProvider_Identity_RegionOverride
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange (142.86s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource (218.86s)
--- PASS: TestAccECSCapacityProvider_Identity_RegionOverride (127.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	537.881s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures	[no test files]

@ewbankkit ewbankkit added the partner Contribution from a partner. label Oct 1, 2025
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% make t T=TestAccECSCapacityProvider_ K=ecs P=3                    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 feat/ecs_managed_instances 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/ecs/... -v -count 1 -parallel 3 -run='TestAccECSCapacityProvider_'  -timeout 360m -vet=off
2025/10/01 11:56:32 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/01 11:56:32 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccECSCapacityProvider_Identity_Basic
=== PAUSE TestAccECSCapacityProvider_Identity_Basic
=== RUN   TestAccECSCapacityProvider_Identity_RegionOverride
=== PAUSE TestAccECSCapacityProvider_Identity_RegionOverride
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource
=== RUN   TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_disappears
=== PAUSE TestAccECSCapacityProvider_disappears
=== RUN   TestAccECSCapacityProvider_managedScaling
=== PAUSE TestAccECSCapacityProvider_managedScaling
=== RUN   TestAccECSCapacityProvider_managedScalingPartial
=== PAUSE TestAccECSCapacityProvider_managedScalingPartial
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSCapacityProvider_clusterFieldValidations
=== PAUSE TestAccECSCapacityProvider_clusterFieldValidations
=== RUN   TestAccECSCapacityProvider_mutualExclusivity
=== PAUSE TestAccECSCapacityProvider_mutualExclusivity
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_basic
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
=== RUN   TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== PAUSE TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
=== RUN   TestAccECSCapacityProvider_updateManagedInstancesProvider
=== PAUSE TestAccECSCapacityProvider_updateManagedInstancesProvider
=== CONT  TestAccECSCapacityProvider_Identity_Basic
=== CONT  TestAccECSCapacityProvider_tags
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withInstanceRequirements (38.12s)
=== CONT  TestAccECSCapacityProvider_updateManagedInstancesProvider
--- PASS: TestAccECSCapacityProvider_tags (54.58s)
=== CONT  TestAccECSCapacityProvider_basic
--- PASS: TestAccECSCapacityProvider_Identity_Basic (55.27s)
=== CONT  TestAccECSCapacityProvider_managedScalingPartial
--- PASS: TestAccECSCapacityProvider_updateManagedInstancesProvider (51.41s)
=== CONT  TestAccECSCapacityProvider_managedScaling
--- PASS: TestAccECSCapacityProvider_basic (35.48s)
=== CONT  TestAccECSCapacityProvider_disappears
--- PASS: TestAccECSCapacityProvider_managedScalingPartial (44.11s)
=== CONT  TestAccECSCapacityProvider_mutualExclusivity
--- PASS: TestAccECSCapacityProvider_mutualExclusivity (2.32s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_basic
--- PASS: TestAccECSCapacityProvider_disappears (26.48s)
=== CONT  TestAccECSCapacityProvider_clusterFieldValidations
--- PASS: TestAccECSCapacityProvider_clusterFieldValidations (2.26s)
=== CONT  TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_basic (38.81s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource
--- PASS: TestAccECSCapacityProvider_createManagedInstancesProvider_withStorageConfiguration (36.92s)
=== CONT  TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange
--- PASS: TestAccECSCapacityProvider_managedScaling (67.26s)
=== CONT  TestAccECSCapacityProvider_Identity_RegionOverride
--- PASS: TestAccECSCapacityProvider_Identity_RegionOverride (53.01s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource (86.29s)
--- PASS: TestAccECSCapacityProvider_Identity_ExistingResource_NoRefresh_NoChange (71.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	232.522s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures	[no test files]

@ewbankkit
Copy link
Contributor Author

@kg-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f154285 into main Oct 1, 2025
68 checks passed
@ewbankkit ewbankkit deleted the feat/ecs_managed_instances branch October 1, 2025 16:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.15.0 milestone Oct 1, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

This functionality has been released in v6.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ECS managed instances

3 participants