Skip to content

Conversation

@ewbankkit
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Additional worker_type values that aren't in the AWS SDK.

Relations

Closes #43446.
Relates aws/aws-sdk-go-v2#3146.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccGlueJob_workerType\|TestAccGlueJob_basic' PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlueJob_workerType\|TestAccGlueJob_basic -timeout 360m -vet=off
2025/08/21 12:58:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/21 12:58:46 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccGlueJob_basic
=== PAUSE TestAccGlueJob_basic
=== RUN   TestAccGlueJob_basicStreaming
=== PAUSE TestAccGlueJob_basicStreaming
=== RUN   TestAccGlueJob_workerType
=== PAUSE TestAccGlueJob_workerType
=== CONT  TestAccGlueJob_basic
=== CONT  TestAccGlueJob_workerType
=== CONT  TestAccGlueJob_basicStreaming
--- PASS: TestAccGlueJob_basic (17.25s)
--- PASS: TestAccGlueJob_basicStreaming (17.26s)
--- PASS: TestAccGlueJob_workerType (58.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	64.049s

…8X` as valid values for `worker_type`.
@ewbankkit ewbankkit requested a review from a team as a code owner August 21, 2025 17:03
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 21, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. labels Aug 21, 2025
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 21, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Just one optional nit on linking upstream

@ewbankkit ewbankkit merged commit 9422b8f into main Aug 21, 2025
57 of 71 checks passed
@ewbankkit ewbankkit deleted the f-aws_glue_job.worker_type-additions branch August 21, 2025 17:37
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.10.0 milestone Aug 21, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 21, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 21, 2025
kg-aws pushed a commit to djglaser/terraform-provider-aws that referenced this pull request Aug 25, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] New Worker Type R and G.12X and G.16

2 participants