Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_route53_records: New data source #40716

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

d/aws_route53_records: New data source #40716

wants to merge 15 commits into from

Conversation

ewbankkit
Copy link
Contributor

Description

Adds the aws_route53_records data source to list the resource records for a Route 53 hosted zone.

Relations

Closes #31768
Closes #24045.
Closes #27851.
Closes #31703.
Closes #38186.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRoute53RecordsDataSource_basic' PKG=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccRoute53RecordsDataSource_basic -timeout 360m
2024/12/28 17:41:45 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53RecordsDataSource_basic
=== PAUSE TestAccRoute53RecordsDataSource_basic
=== CONT  TestAccRoute53RecordsDataSource_basic
--- PASS: TestAccRoute53RecordsDataSource_basic (161.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	166.406s

Siddarthyuvaraj and others added 15 commits June 24, 2024 04:16
@ewbankkit ewbankkit requested a review from a team as a code owner December 28, 2024 22:49
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 28, 2024
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Dec 28, 2024
jar-b
jar-b approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=route53 TESTS="TestAccRoute53RecordsDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53RecordsDataSource_'  -timeout 360m
2025/01/02 10:25:50 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53RecordsDataSource_basic
=== PAUSE TestAccRoute53RecordsDataSource_basic
=== CONT  TestAccRoute53RecordsDataSource_basic
--- PASS: TestAccRoute53RecordsDataSource_basic (183.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    188.209s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
3 participants
@ewbankkit @jar-b @Siddarthyuvaraj