Add new arguments from CreateDbInstance and UpdateDbInstance

[trevorbonas]

Description

• network_type added as an argument, adding IPv6 support.
• port added as an argument.
• deployment_type is now updatable.
  • An update step has been added to TestAccTimestreamInfluxDBDBInstance_deploymentType.
• db_instance_type is now updatable.
  • The test TestAccTimestreamInfluxDBDBInstance_dbInstanceType has been added with an update step.
• allocated_storage is now updatable.
• db_storage_type is now updatable.
• flex.Expand is no longer used in Update to populate an UpdateDbInstanceInput struct. This is because a ValidationException will occur when a DB instance is updated with configuration values it already uses.
• In Update, if secondary_availability_zone is left as unknown, it is set to its previous value. secondary_availability_zone can be left as unknown when tags are updated, which causes an error.
• secondary_availability_zone uses the default value of nil. While unconventional, this prevents an error when updating deployment_type. secondary_availability_zone's value is directly a result of the value of deployment_type.
• awstypes.StatusDeleted has been added as a pending state in waitDBInstanceDeleted. This is because DB instances are first given the status "DELETED" before becoming unreachable. This status is not consistent. Using this status as a target status leads to flaky tests. Using this status as a pending status means Terraform will wait until the instance is unreachable.
• An error in the website documentation for creating an instance with S3 log delivery configuration has been fixed.

Relations

N/A.

References

Updated UpdateDbInstanceInput struct documentation.

Output from Acceptance Testing

% make testacc TESTS=TestAccTimestreamInfluxDBDBInstance PKG=timestreaminfluxdb ACCTEST_PARALLELISM=1 ACCTEST_TIMEOUT=1440m
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 1 -run='TestAccTimestreamInfluxDBDBInstance'  -timeout 1440m -vet=off
2025/01/30 17:23:10 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_null
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_null
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccTimestreamInfluxDBDBInstance_basic
=== PAUSE TestAccTimestreamInfluxDBDBInstance_basic
=== RUN   TestAccTimestreamInfluxDBDBInstance_disappears
=== PAUSE TestAccTimestreamInfluxDBDBInstance_disappears
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== RUN   TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== PAUSE TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== RUN   TestAccTimestreamInfluxDBDBInstance_networkType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_networkType
=== RUN   TestAccTimestreamInfluxDBDBInstance_port
=== PAUSE TestAccTimestreamInfluxDBDBInstance_port
=== RUN   TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== PAUSE TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== RUN   TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
=== PAUSE TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
=== RUN   TestAccTimestreamInfluxDBDBInstance_deploymentType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_deploymentType
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags (1229.48s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnCreate (1076.27s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_deploymentType
--- PASS: TestAccTimestreamInfluxDBDBInstance_deploymentType (1231.09s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_publiclyAccessible
--- PASS: TestAccTimestreamInfluxDBDBInstance_publiclyAccessible (1166.46s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbStorageType
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbStorageType (1411.36s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_allocatedStorage
--- PASS: TestAccTimestreamInfluxDBDBInstance_allocatedStorage (1492.96s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_port
--- PASS: TestAccTimestreamInfluxDBDBInstance_port (1168.10s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_networkType
--- PASS: TestAccTimestreamInfluxDBDBInstance_networkType (2093.89s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
--- PASS: TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration (1055.32s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbInstanceType
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbInstanceType (1598.02s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_disappears
--- PASS: TestAccTimestreamInfluxDBDBInstance_disappears (1274.84s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_basic
--- PASS: TestAccTimestreamInfluxDBDBInstance_basic (1134.06s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_ResourceTag (1101.74s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_IgnoreTags_Overlap_DefaultTag (1148.29s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Replace (934.63s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_ComputedTag_OnUpdate_Add (1084.06s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nonOverlapping (1149.50s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullNonOverlappingResourceTag (1075.09s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_nullOverlappingResourceTag (1075.76s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyProviderOnlyTag (1118.44s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_emptyResourceTag (986.61s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToResourceOnly (1144.57s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_updateToProviderOnly (1035.81s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_overlapping (1159.33s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnCreate (1218.45s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_DefaultTags_providerOnly (1173.88s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Replace (1772.90s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyMap (1175.23s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_AddOnUpdate (1042.75s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_null
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_null (1176.26s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccTimestreamInfluxDBDBInstance_tags_EmptyTag_OnUpdate_Add (871.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb	37381.621s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[trevorbonas]

This PR has been converted to a draft since the AWS SDK for Go v2 will receive new features for Timestream for InfluxDB this week, which will be integrated into this PR.

New arguments have been added to Update.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=TestAccTimestreamInfluxDBDBInstance_basic\|TestAccTimestreamInfluxDBDBInstance_disappears\|TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration\|TestAccTimestreamInfluxDBDBInstance_dbInstanceType\|TestAccTimestreamInfluxDBDBInstance_networkType\|TestAccTimestreamInfluxDBDBInstance_port\|TestAccTimestreamInfluxDBDBInstance_allocatedStorage\|TestAccTimestreamInfluxDBDBInstance_dbStorageType" PKG=timestreaminfluxdb ACCTEST_PARALLELISM=2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/timestreaminfluxdb/... -v -count 1 -parallel 2  -run=TestAccTimestreamInfluxDBDBInstance_basic\|TestAccTimestreamInfluxDBDBInstance_disappears\|TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration\|TestAccTimestreamInfluxDBDBInstance_dbInstanceType\|TestAccTimestreamInfluxDBDBInstance_networkType\|TestAccTimestreamInfluxDBDBInstance_port\|TestAccTimestreamInfluxDBDBInstance_allocatedStorage\|TestAccTimestreamInfluxDBDBInstance_dbStorageType -timeout 360m -vet=off
2025/03/12 14:43:53 Initializing Terraform AWS Provider...
=== RUN   TestAccTimestreamInfluxDBDBInstance_basic
=== PAUSE TestAccTimestreamInfluxDBDBInstance_basic
=== RUN   TestAccTimestreamInfluxDBDBInstance_disappears
=== PAUSE TestAccTimestreamInfluxDBDBInstance_disappears
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbInstanceType
=== RUN   TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== PAUSE TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
=== RUN   TestAccTimestreamInfluxDBDBInstance_networkType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_networkType
=== RUN   TestAccTimestreamInfluxDBDBInstance_port
=== PAUSE TestAccTimestreamInfluxDBDBInstance_port
=== RUN   TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== PAUSE TestAccTimestreamInfluxDBDBInstance_allocatedStorage
=== RUN   TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== PAUSE TestAccTimestreamInfluxDBDBInstance_dbStorageType
=== CONT  TestAccTimestreamInfluxDBDBInstance_basic
=== CONT  TestAccTimestreamInfluxDBDBInstance_networkType
--- PASS: TestAccTimestreamInfluxDBDBInstance_basic (1206.79s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_allocatedStorage
--- PASS: TestAccTimestreamInfluxDBDBInstance_networkType (2164.97s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbStorageType
--- PASS: TestAccTimestreamInfluxDBDBInstance_allocatedStorage (2296.68s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_dbInstanceType
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbStorageType (1811.52s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration
--- PASS: TestAccTimestreamInfluxDBDBInstance_dbInstanceType (1750.24s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_port
--- PASS: TestAccTimestreamInfluxDBDBInstance_logDeliveryConfiguration (1393.78s)
=== CONT  TestAccTimestreamInfluxDBDBInstance_disappears
--- PASS: TestAccTimestreamInfluxDBDBInstance_port (1376.76s)
--- PASS: TestAccTimestreamInfluxDBDBInstance_disappears (1606.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreaminfluxdb	6983.927s

[ewbankkit]

LGTM 🚀.

[johnsonaj]

@trevorbonas thank you for the contribution! 🎉

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.91.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.