-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hsm2m.medium as valid type for hsm_type on aws_cloudhsm_v2_cluster #39206
Add hsm2m.medium as valid type for hsm_type on aws_cloudhsm_v2_cluster #39206
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
…r, and add mode as property
15ed3e9
to
d4c9f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @prestonprice57 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccCloudHSMV2_serial/Cluster' PKG=cloudhsmv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/cloudhsmv2/... -v -count 1 -parallel 20 -run=TestAccCloudHSMV2_serial/Cluster -timeout 720m
=== RUN TestAccCloudHSMV2_serial
=== PAUSE TestAccCloudHSMV2_serial
=== CONT TestAccCloudHSMV2_serial
=== RUN TestAccCloudHSMV2_serial/Cluster
=== RUN TestAccCloudHSMV2_serial/Cluster/basic
=== RUN TestAccCloudHSMV2_serial/Cluster/disappears
=== RUN TestAccCloudHSMV2_serial/Cluster/tags
=== RUN TestAccCloudHSMV2_serial/Cluster/hsmType
--- PASS: TestAccCloudHSMV2_serial (842.01s)
--- PASS: TestAccCloudHSMV2_serial/Cluster (842.01s)
--- PASS: TestAccCloudHSMV2_serial/Cluster/basic (234.07s)
--- PASS: TestAccCloudHSMV2_serial/Cluster/disappears (262.04s)
--- PASS: TestAccCloudHSMV2_serial/Cluster/tags (264.53s)
--- PASS: TestAccCloudHSMV2_serial/Cluster/hsmType (81.36s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2 847.092s
@prestonprice57 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
hsm2m.medium
as a validhsm_type
onaws_cloudhsm_v2_cluster
. This new type has recently been released by Amazon.Add
mode
as a property onaws_cloudhsm_v2_cluster
. This property is required ifhsm_type=hsm2m.medium
Relations
Closes 39018
References
AWS Blog announcement
AWS Docs
Output from Acceptance Testing