Fix errors in JSON produced not matching service expectations

[drewtul]

Fixes schema and generated JSON to match expectations of service per the bug in #38134

Description

Relations

Closes #38134

Output from Acceptance Testing

% make testacc TESTS=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_ PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_'  -timeout 360m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (13.37s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (13.38s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (13.43s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via (14.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     18.260s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

@drewtul Thanks for the contribution 🎉 👏.
As this PR is renaming an attribute we will need to follow best practices -- https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations#provider-attribute-rename -- to avoid backwards compatibility problems.

[drewtul]

@ewbankkit The only reason I didn't do that as the attribute never worked previously, so no working configuration could've been used either of the attributes I changed per the bug I linked to. The generated JSON is rejected by the service and always has been.

If you think it's worth retaining the attribute I can add a compatibility piece in, I just didn't think it was worthwhile in this occasion.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_' PKG=networkmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/networkmanager/... -v -count 1 -parallel 20  -run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_ -timeout 360m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_viaCompat
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_viaCompat
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_viaCompat
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_whenSentTo (8.73s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_viaCompat (8.75s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_serviceInsertion (8.75s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (8.80s)
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_via (8.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	13.648s

[ewbankkit]

@drewtul Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.