Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/lambda_function: fix crash when vpc_config is removed later #3473

Closed
wants to merge 2 commits into from
Closed

resource/lambda_function: fix crash when vpc_config is removed later #3473

wants to merge 2 commits into from

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Feb 21, 2018 •
edited
Loading

Fix #2509

It is also the user case @radeksimko mentioned in #1341 (comment). I hope this PR could help move #1341 forward.

⎇  echo > aws/debug.log ; and make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaFunction_VpcChange'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaFunction_VpcChange -timeout 120m
=== RUN   TestAccAWSLambdaFunction_VpcChange
--- PASS: TestAccAWSLambdaFunction_VpcChange (77.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	77.250s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 21, 2018
@loivis loivis changed the title 2509 lambda function crash when deleting vpc config resource/lambda_function: fix crash when vpc_config is removed later Feb 21, 2018
@loivis loivis force-pushed the 2509-lambda-function-crash-when-deleting-vpc-config branch from b12d3c2 to 8142c58 Compare February 21, 2018 17:28
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 21, 2018
@Ninir Ninir added bug Addresses a defect in current functionality. service/lambda Issues and PRs that pertain to the lambda service. labels Feb 22, 2018
@radeksimko radeksimko added the crash Results from or addresses a Terraform crash or kernel panic. label Mar 1, 2018
@bflad bflad mentioned this pull request Mar 1, 2018
Closed
@giuliocalzolari giuliocalzolari mentioned this pull request Mar 7, 2018
Merged
This was referenced Mar 14, 2018
Closed
Merged
@loivis
Copy link
Contributor Author

loivis commented Aug 10, 2018

There are a few PRs around the issue so close it.

@loivis loivis closed this Aug 10, 2018
@loivis loivis deleted the 2509-lambda-function-crash-when-deleting-vpc-config branch August 10, 2018 08:08
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_lambda_function.lambda-name: unexpected EOF
3 participants
@loivis @radeksimko @Ninir