Skip to content

td/chime service -> sdkv2 #34443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 16, 2023
Merged

td/chime service -> sdkv2 #34443

merged 12 commits into from
Nov 16, 2023

Conversation

@johnsonaj
Copy link
Member

@johnsonaj johnsonaj commented Nov 16, 2023 •
edited
Loading

Description

covert to AWS SDKv2

Relations

References

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccChime_serial" PKG=chime

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChime_serial -timeout 360m
--- PASS: TestAccChime_serial (2351.88s)
    --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials (428.51s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/update (200.77s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/basic (118.63s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/disappears (109.11s)
    --- PASS: TestAccChime_serial/VoiceConnector (339.00s)
        --- PASS: TestAccChime_serial/VoiceConnector/basic (57.87s)
        --- PASS: TestAccChime_serial/VoiceConnector/disappears (40.84s)
        --- PASS: TestAccChime_serial/VoiceConnector/update (95.73s)
        --- PASS: TestAccChime_serial/VoiceConnector/tags (144.56s)
    --- PASS: TestAccChime_serial/VoiceConnectorGroup (336.43s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/basic (93.70s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/disappears (85.04s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/update (157.69s)
    --- PASS: TestAccChime_serial/VoiceConnectorLogging (319.74s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/basic (86.11s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/disappears (81.91s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/update (151.72s)
    --- PASS: TestAccChime_serial/VoiceConnectorOrigination (312.20s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/basic (85.55s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/disappears (75.27s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/update (151.38s)
    --- PASS: TestAccChime_serial/VoiceConnectorStreaming (324.31s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/basic (60.74s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/disappears (59.79s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/update (203.78s)
    --- PASS: TestAccChime_serial/VoiceConnectorTermination (291.69s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/disappears (69.53s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/update (141.22s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/basic (80.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	2355.181s
$ make testacc TESTARGS="-run=TestAccChimeSDKVoice" PKG=chimesdkvoice

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20  -run=TestAccChimeSDKVoice -timeout 360m
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_disappears (194.39s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_basic (208.58s)
    acctest.go:917: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial (214.29s)
    --- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/basic (100.88s)
    --- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/disappears (113.41s)
    --- SKIP: TestAccChimeSDKVoiceGlobalSettings_serial/update (0.00s)
--- PASS: TestAccChimeSDKVoiceSipRule_disappears (262.65s)
--- PASS: TestAccChimeSDKVoiceSipRule_basic (284.02s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_update (319.63s)
--- PASS: TestAccChimeSDKVoiceSipMediaApplication_tags (409.98s)
--- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial (443.59s)
    --- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial/VoiceProfileDomain (443.59s)
        --- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial/VoiceProfileDomain/basic (95.56s)
        --- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial/VoiceProfileDomain/disappears (86.36s)
        --- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial/VoiceProfileDomain/update (120.65s)
        --- PASS: TestAccChimeSDKVoiceVoiceProfileDomain_serial/VoiceProfileDomain/tags (141.01s)
--- PASS: TestAccChimeSDKVoiceSipRule_update (448.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice	451.807s

@github-actions
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/chime Issues and PRs that pertain to the chime service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. labels Nov 16, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 16, 2023
@johnsonaj johnsonaj marked this pull request as ready for review November 16, 2023 18:06
@johnsonaj johnsonaj added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 16, 2023
jar-b
jar-b approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS="-run=TestAccChime_serial" PKG=chime
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20  -run=TestAccChime_serial -timeout 360m

--- PASS: TestAccChime_serial (2397.35s)
    --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials (432.99s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/basic (119.98s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/disappears (110.41s)
        --- PASS: TestAccChime_serial/VoiceConnectorTerminationCredentials/update (202.61s)
    --- PASS: TestAccChime_serial/VoiceConnector (353.74s)
        --- PASS: TestAccChime_serial/VoiceConnector/basic (60.00s)
        --- PASS: TestAccChime_serial/VoiceConnector/disappears (43.05s)
        --- PASS: TestAccChime_serial/VoiceConnector/update (101.54s)
        --- PASS: TestAccChime_serial/VoiceConnector/tags (149.14s)
    --- PASS: TestAccChime_serial/VoiceConnectorGroup (342.22s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/basic (94.17s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/disappears (86.78s)
        --- PASS: TestAccChime_serial/VoiceConnectorGroup/update (161.27s)
    --- PASS: TestAccChime_serial/VoiceConnectorLogging (323.30s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/basic (87.39s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/disappears (82.34s)
        --- PASS: TestAccChime_serial/VoiceConnectorLogging/update (153.57s)
    --- PASS: TestAccChime_serial/VoiceConnectorOrigination (317.16s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/basic (86.49s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/disappears (75.53s)
        --- PASS: TestAccChime_serial/VoiceConnectorOrigination/update (155.14s)
    --- PASS: TestAccChime_serial/VoiceConnectorStreaming (330.57s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/disappears (61.35s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/update (207.02s)
        --- PASS: TestAccChime_serial/VoiceConnectorStreaming/basic (62.20s)
    --- PASS: TestAccChime_serial/VoiceConnectorTermination (297.38s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/basic (81.75s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/disappears (71.99s)
        --- PASS: TestAccChime_serial/VoiceConnectorTermination/update (143.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      2400.710s

@johnsonaj johnsonaj merged commit 4b389cd into main Nov 16, 2023
@johnsonaj johnsonaj deleted the td-chimesdkvoice_sdkv2 branch November 16, 2023 21:39
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 16, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

No one assigned

Labels

client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/chime Issues and PRs that pertain to the chime service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v5.26.0

Development

Successfully merging this pull request may close these issues.

2 participants

@johnsonaj @jar-b