Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Lambda Node.js 20 runtime #34401

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

juancarlosjr97
Copy link
Contributor

@juancarlosjr97 juancarlosjr97 commented Nov 14, 2023

Description

Adding support for node20 - Documents AWS Lambda support for the Node.js 20 runtime.

Relates #34360.

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccLambdaFunction_runtimes' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_runtimes -timeout 360m
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_runtimes (591.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	593.499s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Nov 14, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @juancarlosjr97 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@juancarlosjr97 juancarlosjr97 changed the title Add changelog for node20 release Add support for AWS Lambda Node.js 20 runtime Nov 15, 2023
@ewbankkit ewbankkit added service/lambda Issues and PRs that pertain to the lambda service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2023
@github-actions github-actions bot removed the service/lambda Issues and PRs that pertain to the lambda service. label Nov 15, 2023
@ewbankkit ewbankkit added the service/lambda Issues and PRs that pertain to the lambda service. label Nov 15, 2023
@github-actions github-actions bot removed the service/lambda Issues and PRs that pertain to the lambda service. label Nov 15, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@juancarlosjr97 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8157333 into hashicorp:main Nov 15, 2023
30 checks passed
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 15, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. labels Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants