Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TechDebt]: S3 acceptance test default security settings refactor #30589

Merged
merged 12 commits into from
Apr 10, 2023
Merged

[TechDebt]: S3 acceptance test default security settings refactor #30589

merged 12 commits into from
Apr 10, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Apr 10, 2023 •
edited
Loading

Description

Updates the S3 acceptance test suite to use configurations compatible with the recent changes to S3 default security settings.

Relations

Relates #28353

References

Output from Acceptance Testing

$ make testacc PKG=s3 TESTS=TestAccS3Bucket_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_'  -timeout 180m

--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (30.53s)
=== CONT  TestAccS3Bucket_Tags_withNoSystemTags
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (32.14s)
=== CONT  TestAccS3Bucket_Replication_twoDestination
--- PASS: TestAccS3Bucket_Basic_basic (35.72s)
=== CONT  TestAccS3Bucket_Replication_schemaV2
--- PASS: TestAccS3Bucket_Security_corsSingleMethodAndEmptyOrigin (36.01s)
=== CONT  TestAccS3Bucket_Replication_withoutPrefix
--- PASS: TestAccS3Bucket_Manage_objectLock_deprecatedEnabled (37.37s)
=== CONT  TestAccS3Bucket_Replication_expectVersioningValidationError
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (37.50s)
=== CONT  TestAccS3Bucket_Replication_withoutStorageClass
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning (37.66s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (37.83s)
=== CONT  TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation
--- PASS: TestAccS3Bucket_Manage_objectLockWithVersioning_deprecatedEnabled (38.91s)
=== CONT  TestAccS3Bucket_Basic_acceleration
--- PASS: TestAccS3Bucket_Security_logging (39.19s)
=== CONT  TestAccS3Bucket_Duplicate_UsEast1AltAccount
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccS3Bucket_Duplicate_UsEast1AltAccount (0.00s)
=== CONT  TestAccS3Bucket_Duplicate_UsEast1
--- PASS: TestAccS3Bucket_Tags_basic (39.41s)
=== CONT  TestAccS3Bucket_Duplicate_basic
--- PASS: TestAccS3Bucket_Manage_objectLock_migrate (41.25s)
=== CONT  TestAccS3Bucket_disappears
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (46.75s)
=== CONT  TestAccS3Bucket_Security_corsDelete
--- PASS: TestAccS3Bucket_Manage_lifecycleRemove (49.76s)
=== CONT  TestAccS3Bucket_Basic_requestPayer
--- PASS: TestAccS3Bucket_Duplicate_UsEast1 (11.84s)
=== CONT  TestAccS3Bucket_Security_corsUpdate
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (52.65s)
=== CONT  TestAccS3Bucket_Basic_keyEnabled
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (17.46s)
=== CONT  TestAccS3Bucket_Basic_generatedName
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (56.65s)
=== CONT  TestAccS3Bucket_Basic_namePrefix
--- PASS: TestAccS3Bucket_Duplicate_basic (17.68s)
=== CONT  TestAccS3Bucket_Basic_emptyString
--- PASS: TestAccS3Bucket_Manage_objectLock (57.79s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
--- PASS: TestAccS3Bucket_Tags_ignoreTags (57.85s)
=== CONT  TestAccS3Bucket_Replication_basic
--- PASS: TestAccS3Bucket_Manage_versioning (62.07s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter
--- PASS: TestAccS3Bucket_disappears (23.70s)
=== CONT  TestAccS3Bucket_Basic_forceDestroy
--- PASS: TestAccS3Bucket_Replication_twoDestination (39.23s)
=== CONT  TestAccS3Bucket_Web_simple
--- PASS: TestAccS3Bucket_Security_corsDelete (26.07s)
=== CONT  TestAccS3Bucket_Web_routingRules
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (42.46s)
=== CONT  TestAccS3Bucket_Web_redirect
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (41.71s)
=== CONT  TestAccS3Bucket_Manage_MFADeleteDisabled
--- PASS: TestAccS3Bucket_Basic_keyEnabled (36.50s)
=== CONT  TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled
--- PASS: TestAccS3Bucket_Basic_generatedName (35.08s)
=== CONT  TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled
--- PASS: TestAccS3Bucket_Basic_namePrefix (33.22s)
=== CONT  TestAccS3Bucket_Manage_versioningDisabled
--- PASS: TestAccS3Bucket_Basic_emptyString (32.91s)
=== CONT  TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (32.56s)
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_forceDestroy (29.27s)
=== CONT  TestAccS3Bucket_Replication_RTC_valid
--- PASS: TestAccS3Bucket_Basic_acceleration (61.94s)
=== CONT  TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (41.77s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (66.84s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (68.86s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (57.33s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (59.57s)
--- PASS: TestAccS3Bucket_Manage_MFADeleteDisabled (33.79s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (27.06s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMFADeleteDisabled (28.86s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (30.56s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (31.31s)
--- PASS: TestAccS3Bucket_Web_routingRules (49.68s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (97.52s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (27.47s)
--- PASS: TestAccS3Bucket_Replication_basic (72.91s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (42.75s)
--- PASS: TestAccS3Bucket_Web_simple (64.56s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (139.01s)
--- PASS: TestAccS3Bucket_Web_redirect (61.38s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (111.79s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (64.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 163.286s
$ make testacc PKG=s3 TESTS=TestAccS3BucketACL_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketACL_'  -timeout 180m

--- PASS: TestAccS3BucketACL_disappears (15.59s)
--- PASS: TestAccS3BucketACL_basic (21.05s)
--- PASS: TestAccS3BucketACL_migrate_aclNoChange (29.76s)
--- PASS: TestAccS3BucketACL_migrate_aclWithChange (30.92s)
--- PASS: TestAccS3BucketACL_migrate_grantsWithChange (31.12s)
--- PASS: TestAccS3BucketACL_updateACL (33.95s)
--- PASS: TestAccS3BucketACL_grantToACL (34.32s)
--- PASS: TestAccS3BucketACL_ACLToGrant (35.92s)
--- PASS: TestAccS3BucketACL_updateGrant (38.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 41.585s

$ make testacc PKG=s3 TESTS=TestAccS3BucketInventory_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketInventory_'  -timeout 180m

--- PASS: TestAccS3BucketInventory_basic (17.87s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (17.88s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (19.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 22.603s
$ make testacc PKG=s3 TESTS=TestAccS3BucketLifecycleConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketLifecycleConfiguration_'  -timeout 180m

--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (63.74s)
=== CONT  TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_withChange (197.17s)
=== CONT  TestAccS3BucketLifecycleConfiguration_multipleRules
--- PASS: TestAccS3BucketLifecycleConfiguration_migrate_noChange (197.94s)
=== CONT  TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_intelligentTiering (203.12s)
=== CONT  TestAccS3BucketLifecycleConfiguration_prefix
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRangeAndPrefix (203.27s)
=== CONT  TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionDate_standardIa (203.43s)
=== CONT  TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionStorageClassOnly_intelligentTiering (203.89s)
=== CONT  TestAccS3BucketLifecycleConfiguration_disableRule
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeRange (204.64s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeLessThan (205.46s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionZeroDays_intelligentTiering (206.30s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (207.47s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_Tag (207.71s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_emptyBlock (207.75s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionExpiration (207.77s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThanZero (207.77s)
--- PASS: TestAccS3BucketLifecycleConfiguration_EmptyFilter_NonCurrentVersions (207.78s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Update_filterWithAndToFilterWithPrefix (259.16s)
--- PASS: TestAccS3BucketLifecycleConfiguration_filterWithPrefix (285.26s)
--- PASS: TestAccS3BucketLifecycleConfiguration_ruleAbortIncompleteMultipartUpload (285.27s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_expireMarkerOnly (272.63s)
--- PASS: TestAccS3BucketLifecycleConfiguration_TransitionUpdateBetweenDaysAndDate_intelligentTiering (336.43s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules (189.69s)
--- PASS: TestAccS3BucketLifecycleConfiguration_multipleRules_noFilterOrPrefix (190.18s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Filter_ObjectSizeGreaterThan (190.57s)
--- PASS: TestAccS3BucketLifecycleConfiguration_prefix (190.74s)
--- PASS: TestAccS3BucketLifecycleConfiguration_nonCurrentVersionTransition (190.78s)
--- PASS: TestAccS3BucketLifecycleConfiguration_disableRule (321.01s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 528.000s
$ make testacc PKG=s3 TESTS=TestAccS3BucketLogging_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketLogging_'  -timeout 180m

--- PASS: TestAccS3BucketLogging_disappears (17.99s)
--- PASS: TestAccS3BucketLogging_basic (20.29s)
--- PASS: TestAccS3BucketLogging_migrate_loggingWithChange (33.00s)
--- PASS: TestAccS3BucketLogging_migrate_loggingNoChange (33.18s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (46.37s)
--- PASS: TestAccS3BucketLogging_update (49.52s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (49.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 53.068s
$ make testacc PKG=s3 TESTS=TestAccS3BucketMetric_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketMetric_'  -timeout 180m

--- PASS: TestAccS3BucketMetric_withEmptyFilter (1.86s)
--- PASS: TestAccS3BucketMetric_basic (18.77s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (31.03s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (31.29s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (31.75s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (31.76s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (32.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 35.196s
$ make testacc PKG=s3 TESTS=TestAccS3BucketNotification_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketNotification_'  -timeout 180m

--- PASS: TestAccS3BucketNotification_eventbridge (20.66s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (21.29s)
--- PASS: TestAccS3BucketNotification_topic (21.51s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (31.78s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (38.26s)
--- PASS: TestAccS3BucketNotification_queue (49.57s)
--- PASS: TestAccS3BucketNotification_update (59.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 62.991s

$ make testacc PKG=s3 TESTS=TestAccS3BucketPolicy_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketPolicy_'  -timeout 180m

--- PASS: TestAccS3BucketPolicy_disappears_bucket (16.18s)
--- PASS: TestAccS3BucketPolicy_disappears (19.54s)
--- PASS: TestAccS3BucketPolicy_basic (21.13s)
--- PASS: TestAccS3BucketPolicy_migrate_withChange (30.94s)
--- PASS: TestAccS3BucketPolicy_migrate_noChange (31.46s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (33.33s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (55.25s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (56.83s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (99.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 102.342s
$ make testacc PKG=s3 TESTS=TestAccS3BucketReplicationConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketReplicationConfiguration_'  -timeout 180m

--- PASS: TestAccS3BucketReplicationConfiguration_disappears (53.28s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (281.85s)
=== CONT  TestAccS3BucketReplicationConfiguration_schemaV2SameRegion
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyConfigurationBlock (284.65s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (285.51s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (292.60s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (292.74s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_emptyPrefix (292.88s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (293.35s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (293.44s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_withoutId (293.63s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (293.68s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutId (293.73s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (293.73s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (293.79s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_noChange (300.36s)
--- PASS: TestAccS3BucketReplicationConfiguration_migrate_withChange (300.56s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (310.89s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (310.86s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (311.29s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (263.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (319.71s)

NOTE: Replication configuration test suite currently has one test (TestAccS3BucketReplicationConfiguration_schemaV2SameRegion) causing a panic unrelated to these changes. All other tests are passing.

$ make testacc PKG=s3 TESTS=TestAccS3BucketVersioning_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketVersioning_'  -timeout 180m

--- PASS: TestAccS3BucketVersioning_disappears_bucket (25.80s)
--- PASS: TestAccS3BucketVersioning_disappears (28.52s)
--- PASS: TestAccS3BucketVersioning_Status_disabled (30.27s)
--- PASS: TestAccS3BucketVersioning_basic (31.17s)
--- PASS: TestAccS3BucketVersioning_MFADelete (32.39s)
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (32.91s)
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (33.09s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledNoChange (40.04s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledWithChange (40.41s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (40.77s)
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (41.03s)
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (41.03s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (46.35s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (47.93s)
--- PASS: TestAccS3BucketVersioning_update (63.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 67.034s
$ make testacc PKG=s3 TESTS=TestAccS3BucketWebsiteConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketWebsiteConfiguration_'  -timeout 180m

--- PASS: TestAccS3BucketWebsiteConfiguration_disappears (25.52s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirect (25.69s)
--- PASS: TestAccS3BucketWebsiteConfiguration_Redirect (26.94s)
--- PASS: TestAccS3BucketWebsiteConfiguration_basic (29.90s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_ConditionAndRedirectWithEmptyString (29.92s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_RedirectOnly (30.08s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleNoChange (37.63s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRuleToRoutingRules (38.35s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithRoutingRuleWithChange (39.54s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentNoChange (40.10s)
--- PASS: TestAccS3BucketWebsiteConfiguration_migrate_websiteWithIndexDocumentWithChange (40.24s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRules_updateConditionAndRedirect (40.31s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_MultipleRules (42.90s)
--- PASS: TestAccS3BucketWebsiteConfiguration_update (42.91s)
--- PASS: TestAccS3BucketWebsiteConfiguration_RoutingRule_ConditionAndRedirect (80.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 83.476s
$ make testacc PKG=s3 TESTS=TestAccS3BucketDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketDataSource_'  -timeout 180m

--- PASS: TestAccS3BucketDataSource_basic (15.95s)
--- PASS: TestAccS3BucketDataSource_website (17.16s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 20.408s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 10, 2023
@jar-b jar-b force-pushed the td-aws_s3-acctest-fixes branch from e248da5 to 590ec6b Compare April 10, 2023 14:37
jar-b added 12 commits April 10, 2023 11:12
@jar-b
r/aws_s3_bucket: fix acl test configs
4fa68c4 
this change also removes several tests which relied upon ACL configurations
which are no longer possible using the inline acl attribute. these cases
are already covered by equivalent tests in the corresponding standalone
resource test suite
@jar-b
r/aws_s3_bucket_acl: fix acl test configs
b3bf708 
this change also removes one migration test which relied upon ACL grant configurations
which are no longer possible using the inline acl grant attribute.
@jar-b
r/aws_s3_bucket_inventory: fix acl test configs
ce7ba1f
@jar-b
r/aws_s3_bucket_lifecycle_configuration: fix acl test configs
8da5159
@jar-b
r/aws_s3_bucket_logging: fix acl test configs
f86b544
@jar-b
r/aws_s3_bucket_metric: fix acl test configs
4e8c4cd
@jar-b
r/aws_s3_bucket_notification: fix acl test configs
ea71e46
@jar-b
r/aws_s3_bucket_policy: fix acl test configs
7eadfa5
@jar-b
r/aws_s3_bucket_replication_configuration: fix acl test configs
62c8265
@jar-b
r/aws_s3_bucket_versioning: fix acl test configs
b8270f2
@jar-b
r/aws_s3_bucket_website_configuration: fix acl test configs
24f5bff
@jar-b
d/aws_s3_bucket: fix acl test configs
a236dd9
@jar-b jar-b force-pushed the td-aws_s3-acctest-fixes branch from 590ec6b to a236dd9 Compare April 10, 2023 15:12
@jar-b jar-b marked this pull request as ready for review April 10, 2023 15:13
@jar-b jar-b merged commit 0d75273 into main Apr 10, 2023
@jar-b jar-b deleted the td-aws_s3-acctest-fixes branch April 10, 2023 17:41
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
@jar-b jar-b mentioned this pull request Apr 10, 2023
Merged
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jar-b